Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of GAPIC generator acceptance harness #222

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft

Initial implementation of GAPIC generator acceptance harness #222

wants to merge 39 commits into from

Commits on Oct 14, 2019

  1. Fix typos

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    30cd85d View commit details
    Browse the repository at this point in the history

  2. Bare-bones scaffold for acceptance harness

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    eaec552 View commit details
    Browse the repository at this point in the history

  3. Move most logging to a debug logger 

    The debug logger will be switched on by CLI flags later; right now
it's hard-coded.
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    7b3e100 View commit details
    Browse the repository at this point in the history

  4. Iterate over all suite config dirs. Add a simple suite config.

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    9312158 View commit details
    Browse the repository at this point in the history

  5. Check needed dependencies. Add script to prepare them.

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    1ba8c2c View commit details
    Browse the repository at this point in the history

  6. Start and stop gapic-showcase in the background.

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    f0abe48 View commit details
    Browse the repository at this point in the history

  7. Build gapic-showcase from local tree. 

    Instead of fetching a relese. This is for the development
prepare-to-qualify script.
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    a65893d View commit details
    Browse the repository at this point in the history

  8. Add some comments/TODos

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    4fac512 View commit details
    Browse the repository at this point in the history

  9. use go-trace package for debug statements

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    54ddeb5 View commit details
    Browse the repository at this point in the history

  10. Classify suite files by type

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    1139617 View commit details
    Browse the repository at this point in the history

  11. Add instructions for running protoc w Go plugin 

    Capture the language name and options in preparation for running the
protoc plugin from this acceptance harness
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    8a339c3 View commit details
    Browse the repository at this point in the history

  12. Use packr to get files from disk

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    d09898f View commit details
    Browse the repository at this point in the history

  13. Rename "Suite" to "Scenario" 

    A Suite is a collection of Scenarios
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    c49b73d View commit details
    Browse the repository at this point in the history

  14. Add some TODOs

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    3baf0ac View commit details
    Browse the repository at this point in the history

  15. Create sandbox directory with a per-run timestamp in its name 

    Also fix a bug where we were not crrectly retrieving files from packr.Box
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    feec344 View commit details
    Browse the repository at this point in the history

  16. WIP: Running protoc 

    Need to store files as relative directories
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    683c0ff View commit details
    Browse the repository at this point in the history

  17. Make the file list stored with each scenario be relative paths 

    The paths are relative to the scenario dir (in either the source file
box or in the sandbox)
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    73b3768 View commit details
    Browse the repository at this point in the history

  18. Cosmetic changes 

    protoc still not working
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    60456c2 View commit details
    Browse the repository at this point in the history

  19. Get common proto files in a box

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    ff2b117 View commit details
    Browse the repository at this point in the history

  20. Process top-level .include files and directories

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    508e6c2 View commit details
    Browse the repository at this point in the history

  21. Allow include files anywhere in acceptance/ hierarchy into sandbox

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    85188ef View commit details
    Browse the repository at this point in the history

  22. Better trace the assets read in

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    1389599 View commit details
    Browse the repository at this point in the history

  23. Check the generation step succeded via zero exit code 

    In the future, we'll be able to configure expected failures via a
config file, and check for those as well.

This also includes miscellaneous documentation improvements.
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    2acf5c1 View commit details
    Browse the repository at this point in the history

  24. Make the generation step run with samplegen turned on 

    In the process, constructed a sample config for the echo service and
made the hard-coded generator default be protoc-gen-python_gapic via protoc.
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    238659c View commit details
    Browse the repository at this point in the history

  25. Move qualify to be a gapic-showcase subcommand 

    This creates a package `qualifier`
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    27f00d9 View commit details
    Browse the repository at this point in the history

  26. Remove debugging comments

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    b773222 View commit details
    Browse the repository at this point in the history

  27. Allow passing flags and args to the qualify command

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    8fbe238 View commit details
    Browse the repository at this point in the history

  28. Run showcase servers in process when qualifying 

    This involved refactoring the "run" command so that we can start a
server and not block on it ending.
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    242179f View commit details
    Browse the repository at this point in the history

  29. Check for python plugin in prepare-to-qualify

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    d34b2aa View commit details
    Browse the repository at this point in the history

  30. Make Packr part of the release process. 

    We now officially bundle the acceptance files within the Go binary.
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    44447c3 View commit details
    Browse the repository at this point in the history

  31. Remove startShowcase() and endProcess()

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    34cb76b View commit details
    Browse the repository at this point in the history

  32. Add sanity check in case the assets are empty 

    Otherwise we'll trivially succeed on zero checks.
    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    9265b41 View commit details
    Browse the repository at this point in the history

  33. Remove getAllFiles

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    36a69f8 View commit details
    Browse the repository at this point in the history

  34. Document code and add licenses

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    25eb747 View commit details
    Browse the repository at this point in the history

  35. Update go.mod and go.sum after rebasing to latest main/HEAD

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    c80a225 View commit details
    Browse the repository at this point in the history

  36. Rename the demo test suite so it's called "basic-check"

    @vchudnov-g
    vchudnov-g committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    a7c1bf7 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Minor cosmetic tweaks

    @vchudnov-g
    vchudnov-g committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    a41706a View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Code review changes: code

    @vchudnov-g
    vchudnov-g committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    46f760f View commit details
    Browse the repository at this point in the history

  2. Give the example includes more descriptive names 

    And include a README about them
    @vchudnov-g
    vchudnov-g committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    fe47602 View commit details
    Browse the repository at this point in the history