fix: add basic typescript sample and emit additional types #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
google-cla
bot
added
the
cla: yes
JustinBeckwith
added
the
do not merge
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 11 11
Lines 1846 1846
Branches 123 103 -20
=======================================
Hits 1526 1526
Misses 320 320 Continue to review full report at Codecov.
|
JustinBeckwith
removed
the
do not merge
JustinBeckwith
changed the title
sofisl
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the latest
googleapis-common, which directly exports thegaxiostypes asked for in #2367. It also uses this as a chance to improve the docs, and add a TypeScript specific sample which was asked for in #2453.Fixes #2453
Fixes #2367