From fe745412e18a02f314bda8edf5e665f958c0f241 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Thu, 26 Sep 2024 13:19:59 -0700 Subject: [PATCH 01/16] Delete .github/ISSUE_TEMPLATE/feature_request.md --- .github/ISSUE_TEMPLATE/feature_request.md | 18 ------------------ 1 file changed, 18 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md deleted file mode 100644 index b0327dfa02..0000000000 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ /dev/null @@ -1,18 +0,0 @@ ---- -name: Feature request -about: Suggest an idea for this library -labels: 'type: feature request, priority: p3' ---- - -Thanks for stopping by to let us know something could be better! - -**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response. - - **Is your feature request related to a problem? Please describe.** -A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] - **Describe the solution you'd like** -A clear and concise description of what you want to happen. - **Describe alternatives you've considered** -A clear and concise description of any alternative solutions or features you've considered. - **Additional context** -Add any other context or screenshots about the feature request here. From 37c335355e91ad27a82c82e2a3094e7af12e83a6 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Thu, 26 Sep 2024 13:20:43 -0700 Subject: [PATCH 02/16] Delete .github/ISSUE_TEMPLATE/question.md --- .github/ISSUE_TEMPLATE/question.md | 12 ------------ 1 file changed, 12 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/question.md diff --git a/.github/ISSUE_TEMPLATE/question.md b/.github/ISSUE_TEMPLATE/question.md deleted file mode 100644 index 9732311391..0000000000 --- a/.github/ISSUE_TEMPLATE/question.md +++ /dev/null @@ -1,12 +0,0 @@ ---- -name: Question -about: Ask a question -labels: 'type: question, priority: p3' ---- - -Thanks for stopping by to ask us a question! Please make sure to include: -- What you're trying to do -- What code you've already tried -- Any error messages you're getting - -**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response. From 76194f3ab546372972173bdf0d5110abce878716 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Thu, 26 Sep 2024 13:21:05 -0700 Subject: [PATCH 03/16] Delete .github/ISSUE_TEMPLATE/bug_report.md --- .github/ISSUE_TEMPLATE/bug_report.md | 38 ---------------------------- 1 file changed, 38 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/bug_report.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md deleted file mode 100644 index a4a7799c67..0000000000 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ /dev/null @@ -1,38 +0,0 @@ ---- -name: Bug report -about: Create a report to help us improve -labels: 'type: bug, priority: p2' ---- - -Thanks for stopping by to let us know something could be better! - -**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response. - -1) Is this a client library issue or a product issue? -This is the client library for . We will only be able to assist with issues that pertain to the behaviors of this library. If the issue you're experiencing is due to the behavior of the product itself, please visit the [ Support page]() to reach the most relevant engineers. - -2) Did someone already solve this? - - Search the issues already opened: https://github.com/googleapis/google-api-nodejs-client/issues - - Search the issues on our "catch-all" repository: https://github.com/googleapis/google-cloud-node - - Search or ask on StackOverflow (engineers monitor these tags): http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js - -3) Do you have a support contract? -Please create an issue in the [support console](https://cloud.google.com/support/) to ensure a timely response. - -If the support paths suggested above still do not result in a resolution, please provide the following details. - -#### Environment details - - - OS: - - Node.js version: - - npm version: - - `googleapis` version: - -#### Steps to reproduce - - 1. ? - 2. ? - -Making sure to follow these steps will guarantee the quickest resolution possible. - -Thanks! From e56b373b2b8d190831ea145acac5bb4c0202f3ed Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Tue, 1 Oct 2024 11:25:26 -0700 Subject: [PATCH 04/16] Update package.json --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 4292a8fdda..37e42d7ed3 100644 --- a/package.json +++ b/package.json @@ -89,6 +89,7 @@ "nunjucks": "^3.2.1", "open": "^8.0.0", "p-queue": "^6.0.0", + "pdfmake": "0.2.12", "prettier": "^3.0.0", "proxyquire": "^2.1.3", "rimraf": "^3.0.2", From f8ed767f038a3b84ae3c8890fe5f5686025a1266 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Tue, 1 Oct 2024 11:29:37 -0700 Subject: [PATCH 05/16] Update bug_report.yml --- .github/ISSUE_TEMPLATE/bug_report.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index bc451208ee..44e61a97f2 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -17,23 +17,23 @@ body: guides. options: - label: "Search the issues already opened: - https://github.com/GoogleCloudPlatform/google-cloud-node/issues" + https://github.com/GoogleCloudPlatform/google-cloud-node/issues an\ + d https://github.com/googleapis/google-api-nodejs-client/issues" required: true - label: "Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+nod\ e.js" required: true - - label: "Check our Troubleshooting guide: - https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ - es/troubleshooting" + - label: "Check our Troubleshooting guide: https://github.com/googleapis\ + /google-cloud-node/blob/main/docs/troubleshooting.md" required: true - label: "Check our FAQ: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ es/faq" required: true - label: "Check our libraries HOW-TO: - https://github.com/googleapis/gax-nodejs/blob/main/client-libraries\ - .md" + https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.\ + md" required: true - label: "Check out our authentication guide: https://github.com/googleapis/google-auth-library-nodejs" From c211ba668b9986308a44ab3a70eb20ec59049793 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Tue, 1 Oct 2024 11:29:54 -0700 Subject: [PATCH 06/16] Update close-invalid-link.cjs --- .github/scripts/close-invalid-link.cjs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/scripts/close-invalid-link.cjs b/.github/scripts/close-invalid-link.cjs index ba7d51372a..40e3a7d9c3 100644 --- a/.github/scripts/close-invalid-link.cjs +++ b/.github/scripts/close-invalid-link.cjs @@ -17,16 +17,16 @@ async function closeIssue(github, owner, repo, number) { owner: owner, repo: repo, issue_number: number, - body: 'Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)' + body: "Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)" }); await github.rest.issues.update({ owner: owner, repo: repo, issue_number: number, - state: 'closed' + state: "closed" }); } -module.exports = async ({github, context}) => { +module.exports = async ({ github, context }) => { const owner = context.repo.owner; const repo = context.repo.repo; const number = context.issue.number; @@ -37,12 +37,15 @@ module.exports = async ({github, context}) => { issue_number: number, }); - const isBugTemplate = issue.data.body.includes('Link to the code that reproduces this issue'); + const isBugTemplate = issue.data.body.includes("Link to the code that reproduces this issue"); if (isBugTemplate) { + console.log(`Issue ${number} is a bug template`) try { - const link = issue.data.body.split('\n')[18].match(/(https?:\/\/g?i?s?t?\.?github.com\/.*)/); + const link = issue.data.body.split("\n")[18].match(/(https?:\/\/(gist\.)?github.com\/.*)/)[0]; + console.log(`Issue ${number} contains this link: ${link}`) const isValidLink = (await fetch(link)).ok; + console.log(`Issue ${number} has a ${isValidLink ? "valid" : "invalid"} link`) if (!isValidLink) { await closeIssue(github, owner, repo, number); } From be095287dc7b01622f667f49870298cfc4d5aee0 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Tue, 1 Oct 2024 11:32:25 -0700 Subject: [PATCH 07/16] Update processs_request.md --- .github/ISSUE_TEMPLATE/processs_request.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/processs_request.md b/.github/ISSUE_TEMPLATE/processs_request.md index 9f88fc1f3b..cc1f85761c 100644 --- a/.github/ISSUE_TEMPLATE/processs_request.md +++ b/.github/ISSUE_TEMPLATE/processs_request.md @@ -1,5 +1,5 @@ --- name: Process Request -about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, etc. This issue template should primarily used by internal members. +about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, broken links, etc. ---- \ No newline at end of file +--- From 85e9003ab417a046a961dc1491e695773bb5e1b1 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Tue, 1 Oct 2024 11:32:36 -0700 Subject: [PATCH 08/16] Update processs_request.md --- .github/ISSUE_TEMPLATE/processs_request.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/processs_request.md b/.github/ISSUE_TEMPLATE/processs_request.md index cc1f85761c..93ef0b7449 100644 --- a/.github/ISSUE_TEMPLATE/processs_request.md +++ b/.github/ISSUE_TEMPLATE/processs_request.md @@ -1,5 +1,5 @@ --- name: Process Request -about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, broken links, etc. +about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, broken links. --- From b96938a4823738f29cd53f4eb3ded42ff666f7e6 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Tue, 1 Oct 2024 18:32:53 +0000 Subject: [PATCH 09/16] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .github/ISSUE_TEMPLATE/bug_report.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 44e61a97f2..bc451208ee 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -17,23 +17,23 @@ body: guides. options: - label: "Search the issues already opened: - https://github.com/GoogleCloudPlatform/google-cloud-node/issues an\ - d https://github.com/googleapis/google-api-nodejs-client/issues" + https://github.com/GoogleCloudPlatform/google-cloud-node/issues" required: true - label: "Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+nod\ e.js" required: true - - label: "Check our Troubleshooting guide: https://github.com/googleapis\ - /google-cloud-node/blob/main/docs/troubleshooting.md" + - label: "Check our Troubleshooting guide: + https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ + es/troubleshooting" required: true - label: "Check our FAQ: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ es/faq" required: true - label: "Check our libraries HOW-TO: - https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.\ - md" + https://github.com/googleapis/gax-nodejs/blob/main/client-libraries\ + .md" required: true - label: "Check out our authentication guide: https://github.com/googleapis/google-auth-library-nodejs" From 759c343d40392f0eb8661f271a6e950d9cf25d72 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Tue, 1 Oct 2024 18:33:07 +0000 Subject: [PATCH 10/16] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .github/ISSUE_TEMPLATE/bug_report.yml | 12 ++++++------ .github/scripts/close-invalid-link.cjs | 13 +++++-------- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 44e61a97f2..bc451208ee 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -17,23 +17,23 @@ body: guides. options: - label: "Search the issues already opened: - https://github.com/GoogleCloudPlatform/google-cloud-node/issues an\ - d https://github.com/googleapis/google-api-nodejs-client/issues" + https://github.com/GoogleCloudPlatform/google-cloud-node/issues" required: true - label: "Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+nod\ e.js" required: true - - label: "Check our Troubleshooting guide: https://github.com/googleapis\ - /google-cloud-node/blob/main/docs/troubleshooting.md" + - label: "Check our Troubleshooting guide: + https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ + es/troubleshooting" required: true - label: "Check our FAQ: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ es/faq" required: true - label: "Check our libraries HOW-TO: - https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.\ - md" + https://github.com/googleapis/gax-nodejs/blob/main/client-libraries\ + .md" required: true - label: "Check out our authentication guide: https://github.com/googleapis/google-auth-library-nodejs" diff --git a/.github/scripts/close-invalid-link.cjs b/.github/scripts/close-invalid-link.cjs index 40e3a7d9c3..ba7d51372a 100644 --- a/.github/scripts/close-invalid-link.cjs +++ b/.github/scripts/close-invalid-link.cjs @@ -17,16 +17,16 @@ async function closeIssue(github, owner, repo, number) { owner: owner, repo: repo, issue_number: number, - body: "Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)" + body: 'Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)' }); await github.rest.issues.update({ owner: owner, repo: repo, issue_number: number, - state: "closed" + state: 'closed' }); } -module.exports = async ({ github, context }) => { +module.exports = async ({github, context}) => { const owner = context.repo.owner; const repo = context.repo.repo; const number = context.issue.number; @@ -37,15 +37,12 @@ module.exports = async ({ github, context }) => { issue_number: number, }); - const isBugTemplate = issue.data.body.includes("Link to the code that reproduces this issue"); + const isBugTemplate = issue.data.body.includes('Link to the code that reproduces this issue'); if (isBugTemplate) { - console.log(`Issue ${number} is a bug template`) try { - const link = issue.data.body.split("\n")[18].match(/(https?:\/\/(gist\.)?github.com\/.*)/)[0]; - console.log(`Issue ${number} contains this link: ${link}`) + const link = issue.data.body.split('\n')[18].match(/(https?:\/\/g?i?s?t?\.?github.com\/.*)/); const isValidLink = (await fetch(link)).ok; - console.log(`Issue ${number} has a ${isValidLink ? "valid" : "invalid"} link`) if (!isValidLink) { await closeIssue(github, owner, repo, number); } From 34fcd446bccb361347ffea9668940ad54ba7367f Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Tue, 1 Oct 2024 18:35:54 +0000 Subject: [PATCH 11/16] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .github/ISSUE_TEMPLATE/bug_report.yml | 12 ++++++------ .github/ISSUE_TEMPLATE/processs_request.md | 4 ++-- .github/scripts/close-invalid-link.cjs | 13 +++++-------- 3 files changed, 13 insertions(+), 16 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 44e61a97f2..bc451208ee 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -17,23 +17,23 @@ body: guides. options: - label: "Search the issues already opened: - https://github.com/GoogleCloudPlatform/google-cloud-node/issues an\ - d https://github.com/googleapis/google-api-nodejs-client/issues" + https://github.com/GoogleCloudPlatform/google-cloud-node/issues" required: true - label: "Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+nod\ e.js" required: true - - label: "Check our Troubleshooting guide: https://github.com/googleapis\ - /google-cloud-node/blob/main/docs/troubleshooting.md" + - label: "Check our Troubleshooting guide: + https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ + es/troubleshooting" required: true - label: "Check our FAQ: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ es/faq" required: true - label: "Check our libraries HOW-TO: - https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.\ - md" + https://github.com/googleapis/gax-nodejs/blob/main/client-libraries\ + .md" required: true - label: "Check out our authentication guide: https://github.com/googleapis/google-auth-library-nodejs" diff --git a/.github/ISSUE_TEMPLATE/processs_request.md b/.github/ISSUE_TEMPLATE/processs_request.md index 93ef0b7449..9f88fc1f3b 100644 --- a/.github/ISSUE_TEMPLATE/processs_request.md +++ b/.github/ISSUE_TEMPLATE/processs_request.md @@ -1,5 +1,5 @@ --- name: Process Request -about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, broken links. +about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, etc. This issue template should primarily used by internal members. ---- +--- \ No newline at end of file diff --git a/.github/scripts/close-invalid-link.cjs b/.github/scripts/close-invalid-link.cjs index 40e3a7d9c3..ba7d51372a 100644 --- a/.github/scripts/close-invalid-link.cjs +++ b/.github/scripts/close-invalid-link.cjs @@ -17,16 +17,16 @@ async function closeIssue(github, owner, repo, number) { owner: owner, repo: repo, issue_number: number, - body: "Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)" + body: 'Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)' }); await github.rest.issues.update({ owner: owner, repo: repo, issue_number: number, - state: "closed" + state: 'closed' }); } -module.exports = async ({ github, context }) => { +module.exports = async ({github, context}) => { const owner = context.repo.owner; const repo = context.repo.repo; const number = context.issue.number; @@ -37,15 +37,12 @@ module.exports = async ({ github, context }) => { issue_number: number, }); - const isBugTemplate = issue.data.body.includes("Link to the code that reproduces this issue"); + const isBugTemplate = issue.data.body.includes('Link to the code that reproduces this issue'); if (isBugTemplate) { - console.log(`Issue ${number} is a bug template`) try { - const link = issue.data.body.split("\n")[18].match(/(https?:\/\/(gist\.)?github.com\/.*)/)[0]; - console.log(`Issue ${number} contains this link: ${link}`) + const link = issue.data.body.split('\n')[18].match(/(https?:\/\/g?i?s?t?\.?github.com\/.*)/); const isValidLink = (await fetch(link)).ok; - console.log(`Issue ${number} has a ${isValidLink ? "valid" : "invalid"} link`) if (!isValidLink) { await closeIssue(github, owner, repo, number); } From 8e783306a3424ad6aec9e59edae04361288b6966 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Tue, 1 Oct 2024 18:35:58 +0000 Subject: [PATCH 12/16] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .github/ISSUE_TEMPLATE/bug_report.yml | 12 ++++++------ .github/ISSUE_TEMPLATE/processs_request.md | 4 ++-- .github/scripts/close-invalid-link.cjs | 13 +++++-------- 3 files changed, 13 insertions(+), 16 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 44e61a97f2..bc451208ee 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -17,23 +17,23 @@ body: guides. options: - label: "Search the issues already opened: - https://github.com/GoogleCloudPlatform/google-cloud-node/issues an\ - d https://github.com/googleapis/google-api-nodejs-client/issues" + https://github.com/GoogleCloudPlatform/google-cloud-node/issues" required: true - label: "Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+nod\ e.js" required: true - - label: "Check our Troubleshooting guide: https://github.com/googleapis\ - /google-cloud-node/blob/main/docs/troubleshooting.md" + - label: "Check our Troubleshooting guide: + https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ + es/troubleshooting" required: true - label: "Check our FAQ: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ es/faq" required: true - label: "Check our libraries HOW-TO: - https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.\ - md" + https://github.com/googleapis/gax-nodejs/blob/main/client-libraries\ + .md" required: true - label: "Check out our authentication guide: https://github.com/googleapis/google-auth-library-nodejs" diff --git a/.github/ISSUE_TEMPLATE/processs_request.md b/.github/ISSUE_TEMPLATE/processs_request.md index 93ef0b7449..9f88fc1f3b 100644 --- a/.github/ISSUE_TEMPLATE/processs_request.md +++ b/.github/ISSUE_TEMPLATE/processs_request.md @@ -1,5 +1,5 @@ --- name: Process Request -about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, broken links. +about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, etc. This issue template should primarily used by internal members. ---- +--- \ No newline at end of file diff --git a/.github/scripts/close-invalid-link.cjs b/.github/scripts/close-invalid-link.cjs index 40e3a7d9c3..ba7d51372a 100644 --- a/.github/scripts/close-invalid-link.cjs +++ b/.github/scripts/close-invalid-link.cjs @@ -17,16 +17,16 @@ async function closeIssue(github, owner, repo, number) { owner: owner, repo: repo, issue_number: number, - body: "Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)" + body: 'Issue was opened with an invalid reproduction link. Please make sure the repository is a valid, publicly-accessible github repository, and make sure the url is complete (example: https://github.com/googleapis/google-cloud-node)' }); await github.rest.issues.update({ owner: owner, repo: repo, issue_number: number, - state: "closed" + state: 'closed' }); } -module.exports = async ({ github, context }) => { +module.exports = async ({github, context}) => { const owner = context.repo.owner; const repo = context.repo.repo; const number = context.issue.number; @@ -37,15 +37,12 @@ module.exports = async ({ github, context }) => { issue_number: number, }); - const isBugTemplate = issue.data.body.includes("Link to the code that reproduces this issue"); + const isBugTemplate = issue.data.body.includes('Link to the code that reproduces this issue'); if (isBugTemplate) { - console.log(`Issue ${number} is a bug template`) try { - const link = issue.data.body.split("\n")[18].match(/(https?:\/\/(gist\.)?github.com\/.*)/)[0]; - console.log(`Issue ${number} contains this link: ${link}`) + const link = issue.data.body.split('\n')[18].match(/(https?:\/\/g?i?s?t?\.?github.com\/.*)/); const isValidLink = (await fetch(link)).ok; - console.log(`Issue ${number} has a ${isValidLink ? "valid" : "invalid"} link`) if (!isValidLink) { await closeIssue(github, owner, repo, number); } From 952cffea228e54a205ed88a578d0cfa369507ac9 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Tue, 1 Oct 2024 18:36:10 +0000 Subject: [PATCH 13/16] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .github/ISSUE_TEMPLATE/processs_request.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/processs_request.md b/.github/ISSUE_TEMPLATE/processs_request.md index 93ef0b7449..9f88fc1f3b 100644 --- a/.github/ISSUE_TEMPLATE/processs_request.md +++ b/.github/ISSUE_TEMPLATE/processs_request.md @@ -1,5 +1,5 @@ --- name: Process Request -about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, broken links. +about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, etc. This issue template should primarily used by internal members. ---- +--- \ No newline at end of file From 61eee4e4681bff7ad77122e6766d1f1134a6255a Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Tue, 1 Oct 2024 18:36:38 +0000 Subject: [PATCH 14/16] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .github/ISSUE_TEMPLATE/processs_request.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/processs_request.md b/.github/ISSUE_TEMPLATE/processs_request.md index 93ef0b7449..9f88fc1f3b 100644 --- a/.github/ISSUE_TEMPLATE/processs_request.md +++ b/.github/ISSUE_TEMPLATE/processs_request.md @@ -1,5 +1,5 @@ --- name: Process Request -about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, broken links. +about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, etc. This issue template should primarily used by internal members. ---- +--- \ No newline at end of file From 449912d9f0bf95370a3ac959648f1ab607c5fb2e Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Tue, 1 Oct 2024 12:35:54 -0700 Subject: [PATCH 15/16] Update .OwlBot.lock.yaml --- .github/.OwlBot.lock.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml index 460f67f2b6..3ee7284d57 100644 --- a/.github/.OwlBot.lock.yaml +++ b/.github/.OwlBot.lock.yaml @@ -13,5 +13,5 @@ # limitations under the License. docker: image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest - digest: sha256:a5af6af827a9fffba373151e1453b0498da288024cdd16477900dd42857a42e0 + digest: sha256:609822e3c09b7a1bd90b99655904609f162cc15acb4704f1edf778284c36f429 # created: 2024-09-20T20:26:11.126243246Z From 2cdec93ffcf7ba47b8e2423ee0dc8cc421d7dc94 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Tue, 1 Oct 2024 19:39:06 +0000 Subject: [PATCH 16/16] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20?= =?UTF-8?q?post-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- .github/ISSUE_TEMPLATE/bug_report.yml | 12 ++++++------ .github/ISSUE_TEMPLATE/processs_request.md | 5 ++--- .github/scripts/close-invalid-link.cjs | 5 ++++- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index bc451208ee..24b5a410a3 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -24,12 +24,12 @@ body: e.js" required: true - label: "Check our Troubleshooting guide: - https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ - es/troubleshooting" + https://github.com/googleapis/google-cloud-node/blob/main/docs/trou\ + bleshooting.md" required: true - label: "Check our FAQ: - https://googlecloudplatform.github.io/google-cloud-node/#/docs/guid\ - es/faq" + https://github.com/googleapis/google-cloud-node/blob/main/docs/faq.\ + md" required: true - label: "Check our libraries HOW-TO: https://github.com/googleapis/gax-nodejs/blob/main/client-libraries\ @@ -55,9 +55,9 @@ body: behavior you are experiencing. If the behavior is the same, it means that you are likely experiencing a bug with the API itself. In that case, please submit an issue to the API team, either by submitting an - issue in its issue tracker https://cloud.google.com/support/docs/issue-trackers, or by + issue in its issue tracker (https://cloud.google.com/support/docs/issue-trackers), or by submitting an issue in its linked tracker in the .repo-metadata.json - file + file validations: required: true - type: input diff --git a/.github/ISSUE_TEMPLATE/processs_request.md b/.github/ISSUE_TEMPLATE/processs_request.md index 9f88fc1f3b..45682e8f11 100644 --- a/.github/ISSUE_TEMPLATE/processs_request.md +++ b/.github/ISSUE_TEMPLATE/processs_request.md @@ -1,5 +1,4 @@ --- name: Process Request -about: Submit a process request to the library. Process requests are any requests related to library infrastructure, including CI/CD, publishing, releasing, etc. This issue template should primarily used by internal members. - ---- \ No newline at end of file +about: Submit a process request to the library. Process requests are any requests related to library infrastructure, for example CI/CD, publishing, releasing, broken links. +--- diff --git a/.github/scripts/close-invalid-link.cjs b/.github/scripts/close-invalid-link.cjs index ba7d51372a..d7a3688e75 100644 --- a/.github/scripts/close-invalid-link.cjs +++ b/.github/scripts/close-invalid-link.cjs @@ -40,9 +40,12 @@ module.exports = async ({github, context}) => { const isBugTemplate = issue.data.body.includes('Link to the code that reproduces this issue'); if (isBugTemplate) { + console.log(`Issue ${number} is a bug template`) try { - const link = issue.data.body.split('\n')[18].match(/(https?:\/\/g?i?s?t?\.?github.com\/.*)/); + const link = issue.data.body.split('\n')[18].match(/(https?:\/\/(gist\.)?github.com\/.*)/)[0]; + console.log(`Issue ${number} contains this link: ${link}`) const isValidLink = (await fetch(link)).ok; + console.log(`Issue ${number} has a ${isValidLink ? 'valid' : 'invalid'} link`) if (!isValidLink) { await closeIssue(github, owner, repo, number); }