remove bug

googleapis · Dec 9, 2024 · e9c05ce · e9c05ce
1 parent cf9fd55
commit e9c05ce
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 18 deletions.
diff --git a/Storage/src/SigningHelper.php b/Storage/src/SigningHelper.php
@@ -920,9 +920,5 @@ private function retrySignBlob(callable $signBlobFn, string $resourceName = 'sig
                 }
             }
         }
-
-        throw new \RuntimeException(
-            'Failed to sign message after maximum attempts.'
-        );
     }
 }
diff --git a/Storage/tests/Unit/SigningHelperTest.php b/Storage/tests/Unit/SigningHelperTest.php
@@ -836,20 +836,6 @@ public function testRetrySignBlobNonRetryableError()
 
         $this->assertEquals('Non-retryable error', $res);
     }
-
-    public function testRetrySignBlobRetriesExhausted()
-    {
-        $this->expectException(\RuntimeException::class);
-        $this->expectExceptionMessage('Failed to sign message after maximum attempts.');
-
-        $signBlobFn = function () {
-            throw new ServiceException('Transient error', 503);
-        };
-
-        $res = $this->helper->proxyPrivateMethodCall('retrySignBlob', [
-            $signBlobFn
-        ]);
-    }
 }
 
 //@codingStandardsIgnoreStart
-Original file line number
+Diff line change
@@ Expand Up @@
                     }
                 }
             }
-            throw new \RuntimeException(
-                'Failed to sign message after maximum attempts.'
-            );
         }
     }