Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [AiPlatform] add workbench_runtime and kernel_name to NotebookExecutionJob #7881

Merged
merged 2 commits into from
Dec 6, 2024
Merged

feat: [AiPlatform] add workbench_runtime and kernel_name to NotebookExecutionJob #7881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0460b93
feat: add workbench_runtime and kernel_name to NotebookExecutionJob
gcf-owl-bot[bot] Dec 4, 2024
994de89
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified AiPlatform/metadata/V1/NotebookExecutionJob.php
View file
Open in desktop
Binary file not shown.
92 changes: 88 additions & 4 deletions AiPlatform/src/V1/NotebookExecutionJob.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 34 additions & 0 deletions AiPlatform/src/V1/NotebookExecutionJob/WorkbenchRuntime.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions AiPlatform/tests/Unit/V1/Client/NotebookServiceClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,13 +299,15 @@ public function createNotebookExecutionJobTest()
$name = 'name3373707';
$displayName = 'displayName1615086568';
$scheduleResourceName = 'scheduleResourceName-627484556';
$kernelName = 'kernelName-497416883';
$expectedResponse = new NotebookExecutionJob();
$expectedResponse->setNotebookRuntimeTemplateResourceName($notebookRuntimeTemplateResourceName);
$expectedResponse->setGcsOutputUri($gcsOutputUri);
$expectedResponse->setExecutionUser($executionUser);
$expectedResponse->setName($name);
$expectedResponse->setDisplayName($displayName);
$expectedResponse->setScheduleResourceName($scheduleResourceName);
$expectedResponse->setKernelName($kernelName);
$anyResponse = new Any();
$anyResponse->setValue($expectedResponse->serializeToString());
$completeOperation = new Operation();
Expand Down Expand Up @@ -955,13 +957,15 @@ public function getNotebookExecutionJobTest()
$name2 = 'name2-1052831874';
$displayName = 'displayName1615086568';
$scheduleResourceName = 'scheduleResourceName-627484556';
$kernelName = 'kernelName-497416883';
$expectedResponse = new NotebookExecutionJob();
$expectedResponse->setNotebookRuntimeTemplateResourceName($notebookRuntimeTemplateResourceName);
$expectedResponse->setGcsOutputUri($gcsOutputUri);
$expectedResponse->setExecutionUser($executionUser);
$expectedResponse->setName($name2);
$expectedResponse->setDisplayName($displayName);
$expectedResponse->setScheduleResourceName($scheduleResourceName);
$expectedResponse->setKernelName($kernelName);
$transport->addResponse($expectedResponse);
// Mock request
$formattedName = $gapicClient->notebookExecutionJobName('[PROJECT]', '[LOCATION]', '[NOTEBOOK_EXECUTION_JOB]');
Expand Down
Loading