Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update owlbot config: deep-preserve-regex to include TelemetryMetrics.java #2611

Merged
merged 1 commit into from
Aug 19, 2024
Merged

chore: update owlbot config: deep-preserve-regex to include TelemetryMetrics.java #2611

merged 1 commit into from
Aug 19, 2024

Conversation

PhongChuong
Copy link
Contributor

TelemetryMetrics.java was not included to the deep-preserve-regex in PR#2606 when it was introduced. As a result, it is being auto removed in PR#2609.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2610 ☕️

@PhongChuong PhongChuong requested review from a team as code owners August 19, 2024 15:45
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Aug 19, 2024
@PhongChuong PhongChuong mentioned this pull request Aug 19, 2024
Closed
@PhongChuong PhongChuong merged commit 21245d0 into main Aug 19, 2024
21 checks passed
@PhongChuong PhongChuong deleted the i2610 branch August 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrawal-siddharth agrawal-siddharth agrawal-siddharth approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe chalmerlowe is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update deep-preserve-regex to include TelemetryMetrics.java
2 participants
@PhongChuong @agrawal-siddharth