Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update BigQuerySchemaUtil to use non-deprecated hasExtension #2732

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: update BigQuerySchemaUtil to use non-deprecated hasExtension #2732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...igquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/BigQuerySchemaUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
*/
package com.google.cloud.bigquery.storage.v1;

import com.google.protobuf.DescriptorProtos.FieldOptions;
import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.ExtensionLite;
import java.nio.charset.StandardCharsets;
import java.util.Base64;

Expand Down Expand Up @@ -74,8 +76,12 @@ public static String generatePlaceholderFieldName(String fieldName) {
* @return columnName annotation if present, otherwise return the field name.
*/
public static String getFieldName(FieldDescriptor fieldDescriptor) {
return fieldDescriptor.getOptions().hasExtension(AnnotationsProto.columnName)
? fieldDescriptor.getOptions().getExtension(AnnotationsProto.columnName)
return fieldDescriptor
.getOptions()
.hasExtension((ExtensionLite<FieldOptions, String>) AnnotationsProto.columnName)
? fieldDescriptor
.getOptions()
.getExtension((ExtensionLite<FieldOptions, String>) AnnotationsProto.columnName)
: fieldDescriptor.getName();
}
}
Loading