Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: organize with Older and prerelease packages #192

Merged
merged 5 commits into from
Sep 20, 2023
Merged

feat: organize with Older and prerelease packages #192

merged 5 commits into from
Sep 20, 2023

Conversation

burkedavison
Copy link
Contributor

No description provided.

@burkedavison burkedavison marked this pull request as ready for review August 29, 2023 18:35
@burkedavison burkedavison requested a review from a team as a code owner August 29, 2023 18:35
alicejli
alicejli reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@alicejli alicejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarifying questions on how this works; thanks for your work on this! If possible to add mocked staging just to double-check this renders properly that would be helpful as well.

third_party/docfx-doclet-143274/src/test/java/com/microsoft/util/ApiVersionTest.java Outdated Show resolved Hide resolved
third_party/docfx-doclet-143274/src/main/java/com/microsoft/build/YmlFilesBuilder.java Show resolved Hide resolved
third_party/docfx-doclet-143274/src/main/java/com/microsoft/lookup/PackageLookup.java Show resolved Hide resolved
third_party/docfx-doclet-143274/src/main/java/com/microsoft/lookup/PackageLookup.java Show resolved Hide resolved
@burkedavison
Copy link
Contributor Author

Staging complete, reviewed, and discussed.

alicejli
alicejli approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@alicejli alicejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Putting this into a comment for future reference:

  1. Follow up needed on handling stub packages
  2. Current implementation selects a single package to highlight. If there is need in the future for either a manual override or for multiple packages to be highlighted, that will be a new FR.

@burkedavison burkedavison merged commit caf61a8 into main Sep 20, 2023
7 checks passed
@burkedavison burkedavison deleted the organize-older-and-prerelease-versions branch September 20, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicejli alicejli alicejli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burkedavison @alicejli