feat: Left-hand Navigation: Group stub packages under parent #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burkedavison
changed the title
alicejli
reviewed
Sep 25, 2023
There was a problem hiding this comment.
This looks great! Two thoughts:
-
Do you mind staging
java-bigtableas well? They have a couple ofstub*packages that would be good to confirm how they show up (e.g. https://cloud.google.com/java/docs/reference/google-cloud-bigtable/latest/com.google.cloud.bigtable.data.v2.stub.changestream) -
There currently isn't an implementation to opt-out for this change right? I think that's fine for this change, but wanted to double check.
|
Mmm. Good catch @alicejli on
|
|
@alicejli : Staging complete. Ready for final review. |
alicejli
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cl/561379976 for staging link.