feat: Left-hand navigation API-versioned package organization #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burkedavison
commented
Oct 2, 2023
third_party/docfx-doclet-143274/src/main/java/com/microsoft/lookup/PackageLookup.java
Outdated
Show resolved
Hide resolved
alicejli
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Nice changes!
- I'm sorry - I staged speech as well for the new package overviews so I think I overwrote your changes in the devsite for speech (bigtable is good though!)
- Looking at bigtable, I'm wondering if it makes sense to add a section for "Stub Packages" instead of including the stub package directly (https://screenshot.googleplex.com/5KAZPbyNeRBcW4H)
third_party/docfx-doclet-143274/src/main/java/com/microsoft/build/ClassBuilder.java
Show resolved
Hide resolved
third_party/docfx-doclet-143274/src/main/java/com/microsoft/model/ApiVersionPackageToc.java
Show resolved
Hide resolved
third_party/docfx-doclet-143274/src/main/java/com/microsoft/lookup/PackageLookup.java
Show resolved
Hide resolved
Yes - I like this idea much better. Implementing. EDIT: Speech staging updated with "Stub packages" grouping change |
alicejli
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See staging links in cl/561379976