Skip to content

Commit

Permalink
Merge pull request #187 from googlecodelabs/build-fixes
Browse files Browse the repository at this point in the history
Slight build changes to allow SCSS imports into devsite
  • Loading branch information
Nicolas Garnier authored Mar 7, 2019
2 parents c01d1f3 + 8069422 commit eca60f2
Show file tree
Hide file tree
Showing 4 changed files with 45 additions and 28 deletions.
6 changes: 2 additions & 4 deletions codelab-elements/google-codelab-index/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ sass_library(
sass_library(
name = "cards_scss",
srcs = ["_cards.scss"],
deps = [":categories_scss"],
)

sass_library(
Expand All @@ -73,10 +74,7 @@ sass_library(
sass_binary(
name = "google_codelab_index_scss_bin",
src = "google_codelab_index.scss",
deps = [
":cards_scss",
":categories_scss",
]
deps = [":cards_scss"],
)

closure_js_template_library(
Expand Down
11 changes: 6 additions & 5 deletions codelab-elements/google-codelab/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ closure_js_binary(
sass_library(
name = "google_codelab_scss",
srcs = ["google_codelab.scss"],
deps = [
":google_codelab_drawer_scss",
":google_codelab_steps_scss",
],
)

sass_library(
Expand All @@ -57,11 +61,8 @@ sass_library(

sass_binary(
name = "google_codelab_scss_bin",
src = "google_codelab.scss",
deps = [
":google_codelab_drawer_scss",
":google_codelab_steps_scss",
]
src = "index.scss",
deps = [":google_codelab_scss"],
)

closure_js_template_library(
Expand Down
19 changes: 0 additions & 19 deletions codelab-elements/google-codelab/google_codelab.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,6 @@
* limitations under the License.
*/

html, body {
height: 100%;
width: 100%;
margin: 0;
padding: 0;
}
body {
font-family: "Roboto",sans-serif;
transition: opacity ease-in 0.2s;
}

* {
box-sizing: border-box;
}

[hidden] {
display: none !important;
}

google-codelab {
display: flex;
width: 100%;
Expand Down
37 changes: 37 additions & 0 deletions codelab-elements/google-codelab/index.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/**
* @license
* Copyright 2018 Google Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

html, body {
height: 100%;
width: 100%;
margin: 0;
padding: 0;
}
body {
font-family: "Roboto",sans-serif;
transition: opacity ease-in 0.2s;
}

* {
box-sizing: border-box;
}

[hidden] {
display: none !important;
}

@import "google_codelab.scss"

0 comments on commit eca60f2

Please sign in to comment.