Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding new files #33

Open
wants to merge 1 commit into
base: new-codelabs
Choose a base branch
from
Open

adding new files #33

wants to merge 1 commit into from

Conversation

musiciancodes
Copy link
Contributor

Again - code review before I rewrite the whole codelab?

diminishedprime
diminishedprime suggested changes Jan 27, 2020
View reviewed changes
Copy link

@diminishedprime diminishedprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I really need addressed before approving is my very last comment about what files we want to include.

barchart-codelab/dist/index.html Show resolved Hide resolved
barchart-codelab/src/index.js Show resolved Hide resolved
barchart-codelab/src/index.js Show resolved Hide resolved
barchart-codelab/src/index.js Show resolved Hide resolved
barchart-codelab/src/index.js Show resolved Hide resolved
barchart-codelab/src/index.js Show resolved Hide resolved
barchart-codelab/src/index.js Show resolved Hide resolved
barchart-codelab/src/index.js Show resolved Hide resolved
barchart-codelab/src/index.js Show resolved Hide resolved
barchart-codelab/webpack.config.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diminishedprime diminishedprime diminishedprime requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@musiciancodes @diminishedprime