Refactor ninja #102
Merged
Refactor ninja #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the ninja builder logic so it's easier to add arguments. Currently, if you want to add a new CLI argument, you need to add it to main, _diffbrowsers, _diffenator and ninja module (~10 functions). This is a complete pita so my aim in this PR is to allow you to only define the new args in main and they should be available all the way down to the html templates. The _diffenator and _diffbrowsers scripts simple take **kwargs and to cut down on the function args in ninja.py, I've used a builder pattern.
The next pr will refactor the html module so we need to do less argument passing.