Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding autoSwitch for diff browsers proofer #129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

juandelperal
Copy link

This enables the automatic switching of fonts (new vs old) every 1.25 secs.
This helps to compare the versions without clicking all the time.

If the user clicks the old/new button, then the switching stops.

Demo:
ScreenRecording2024-01-30at11 39 00-ezgif com-video-to-gif-converter

PS. I couldn't test it compiles the HTML properly, just added the snippets in the template

@m4rc1e
Copy link
Collaborator

m4rc1e commented Feb 13, 2024

Sorry for not looking at this sooner.

@m4rc1e

This comment was marked as outdated.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Feb 13, 2024

Seems the toggle has been broken for the other pages. I get the following traceback if I open up a page other than proofer.html

Uncaught ReferenceError: autoSwitch is not defined
    at HTMLDivElement.switchFonts (Black-Bold-ExtraBold-Medium-diffbrowsers_waterfall.html:638:25)

Since I like the feature, I don't mind fixing this but it may take me a while to get round to it.

@juandelperal
Copy link
Author

Nice!
I can help with it. How do I build or run tests locally?

@juandelperal
Copy link
Author

I (blindly) added a possible fix, but I cant generate the HTMLs properly
I tried using
python src/diffenator2/__main__.py diff -fb ...

but it seems that I'm getting a cached version, as the generated htmls don't show the changes I am trying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants