Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: Add opentype feature picker #83

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Aug 2, 2023

This PR implements an OpenType feature picker in the html views. This feature was requested by @vv-monsalve (great idea btw).

Screenshot 2023-08-02 at 14 55 31

Since the text boxes are also contenteditable, it's becoming a very nice playground to test out custom user text, similar to Impallari's tester.

@m4rc1e m4rc1e merged commit 3a63bba into googlefonts:main Aug 2, 2023
5 checks passed
@vv-monsalve
Copy link
Contributor

Working beautifully! Thanks

@vv-monsalve
Copy link
Contributor

Updating the report. It worked perfectly (without reported errors) at the proof option.

However, when using it with the diff option, the output folder was created, but it reported two different errors at two different run times:

  • Using the --imgs option:

    ValueError: height and width must be > 0
    [2/2] _diffbrowsers diff -fb "/Users/v... ".*" --imgs --filter-styles "Regular"
    ninja: build stopped: subcommand failed.
    
  • Without using --imgs option

    ValueError: height and width must be > 0
    ninja: build stopped: subcommand failed.
    

I'm attaching here a .zip file that includes

  • The output folder (which includes the fonts to replicate the test)
  • A .txt file where I copy/paste both full tracebacks.

qaPraise-L-01-diffOT.zip

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Aug 2, 2023

Thanks, I think this is related to #82 instead. i'll roll a fix now.

@m4rc1e m4rc1e mentioned this pull request Aug 2, 2023
@vv-monsalve
Copy link
Contributor

i'll roll a fix now.

Could the OT picker include the positional alternates (fina, init) like this one (second image)?

Posting it here since you'll work on the fix. Let me know if you prefer to track this in a new issue, and I'll open one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants