Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hhea/vhea numberOfHMetrics has become number_of_long_metrics #1213

Open
simoncozens opened this issue Oct 31, 2024 · 0 comments
Open

hhea/vhea numberOfHMetrics has become number_of_long_metrics #1213

simoncozens opened this issue Oct 31, 2024 · 0 comments

Comments

@simoncozens
Copy link
Contributor

Generally the names of fields in read-fonts follows the names in the OpenType specification; so it's confusing when they don't.

The spec has

uint16 numberOfHMetrics Number of hMetric entries in 'hmtx' table

but hhea.rs has:

    /// Number of LongMetric entries in 'hmtx'/'vmtx' table
    number_of_long_metrics: u16,

read-fonts's is probably a better name, but it causes a mental "wait, are these the same thing or not?" moment. A doc comment would be helpful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simoncozens