[write] Add common util for computing searchRange #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is shared in a few places, so it makes sense to have a single implementation. (It is used in the kern table, which is coming up)
rsheeter
reviewed
Oct 22, 2024
| //https://github.com/fonttools/fonttools/blob/729b3d2960ef/Lib/fontTools/ttLib/ttFont.py#L1147 | ||
| /// calculate searchRange, entrySelector, and rangeShift | ||
| /// | ||
| /// these values are used in various tables. |
There was a problem hiding this comment.
I suggest enumerating them non-exclusively, e.g.
These values are used in at least the following tables:
* [OpenType font table directory](https://learn.microsoft.com/en-us/typography/opentype/spec/otff#table-directory)
* [cmap subtable format 4](https://learn.microsoft.com/en-us/typography/opentype/spec/cmap#format-4-segment-mapping-to-delta-values)
...others...
```
rsheeter
reviewed
Oct 22, 2024
| range_shift: range_shift.try_into().unwrap(), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Add a test, perhaps based on the sample at https://learn.microsoft.com/en-us/typography/opentype/spec/cmap#format-4-segment-mapping-to-delta-values?
There was a problem hiding this comment.
...and based on you comment, one for 0?
rsheeter
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is shared in a few places, so it makes sense to have a single implementation.
Ran into this in the context of the
kerntable, which I'll PR shortly; this code is shared in a few places.(CI is failing for other reasons, so let's hold off on this until that gets cleared up)