Avoid various overflows in CFF #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add targeted `wrapping_add` and `wrapping_sub` calls to avoid panics on arithmetic overflows for the specific case in #1193
drott
reviewed
Oct 21, 2024
| @@ -224,6 +224,12 @@ impl Stack { | |||
| } else { | |||
| Fixed::from_i32(*value) | |||
| }; | |||
| // See <https://github.com/googlefonts/fontations/issues/1193> | |||
| // The "DIN Alternate" font contains incorrect blue values | |||
| // that cause an overflow in this computation. FreeType does | |||
There was a problem hiding this comment.
Optional: Would you have a link to the equivalent logic in FreeType similar to this delta accumulation here?
There was a problem hiding this comment.
The equivalent logic is here: https://gitlab.freedesktop.org/freetype/freetype/-/blob/57617782464411201ce7bbc93b086c1b4d7d84a5/src/cff/cffparse.c#L1431 along with the "fixed" case below. I'll add this link to the code.
|
Confirmed locally to enable the display of the DIN font using Fontations in Chromium. |
dfrg
added a commit
that referenced
this pull request
Oct 22, 2024
Add targeted `wrapping_add` and `wrapping_sub` calls to avoid panics on arithmetic overflows for the specific case in #1193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add targeted
wrapping_addandwrapping_subcalls to avoid panics on arithmetic overflows for the specific case in #1193