[read-fonts] avoid overflow in private dict range #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another overflow when computing the range for a private dict. ref https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71746 and https://oss-fuzz.com/testcase?key=4591358306746368
rsheeter
approved these changes
Oct 23, 2024
anthrotype
added a commit
that referenced
this pull request
Nov 1, 2024
```
$ cargo release changes
Changes for read-fonts from read-fonts-v0.23.0 to 0.23.1
7914440 [IFT] enforce loca offset sortedness in glyph keyed patching.
9bed00d [IFT] Add checks in glyph keyed patches.
f5e359d [read-fonts] helper methods for layout tables (#1208)
d52fd0c [read-fonts] avoid overflow in private dict range (#1203)
Changes for write-fonts from write-fonts-v0.29.0 to 0.30.0
002872e define OtRound for/to float types
aa417e7 [write] Fixup doctest
fa707c0 write-fonts: Fix `clippy::single_match` lint
1110a3f [IFT] Add codegen definitions for Glyph Keyed patches.
a9377e3 Mention trait in first example
b4bea97 Highlight to_owned_table more strongly
221c525 [IFT] Add a CompatibilityId type.
f535d81 [IFT] in font_patch.rs add public method comments.
a8ae76d Fix pluralization of 'patch' in codegen.
f292aeb [ift] Finish implementing support for TableKeyed patches.
8eff075 [ift] Begin implementing per table brotli patches.
d4e29ac [read-fonts] add hdmx table (#1164)
6364aef [codegen] From<Lookup<_>> for lookup enums
79254d1 Regen the table
cd89d23 Generate docs for most features on docs.rs
5780ca0 avar2 support (#1120)
1da14b0 [codegen] Support explicit #[count] arg for VarLenArray
ed12575 [clippy] Push the rock back up the hill
0e31241 Make traversal non-default feature
a9d4f49 IFT Format 2: add handling for reading in id strings.
7c5e968 IFT Format 2: Respect the 'ignored' flag bit.
6b5de38 Switch codepoint_data to be non conditional now that it can be supported.
6a2b474 s/enty/entry/
5f116df Cleanup unused CopyIndices table in IFT Format 2.
6cfaf56 Add basic test of format 2 parsing.
ee9b0fd Update IFT format 2 decoding to add codepoint set parsing.
f8b37ba Add calculation of entry id to format 2 decoding.
91ece77 Use if_cond(any_flags(..)) to control presence of codepoint fields.
1491439 Begin to implement parsing of entries in IFT format 2.
da318c0 Switch IFT Format 1 glyph_count to u24.
45b2105 [codegen] non-conditional fields after conditionals
b631b7c [write-fonts] post table: de-duplicate psNames
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another overflow when computing the range for a private dict.
ref https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=71746 and https://oss-fuzz.com/testcase?key=4591358306746368
First commit contains a failing test.