[write-fonts] glyf & loca improvements #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
force-pushed
the
glyf-loca-improvements
branch
from
f591170
to
0af87b9
Compare
Merged
dfrg
approved these changes
Aug 3, 2023
| } | ||
|
|
||
| /// 'true' if the glyph contains no contours or components | ||
| pub fn is_empty(&self) -> bool { |
There was a problem hiding this comment.
General curiosity: should we have an Empty variant? This is a bit weird on the read-fonts side too. I believe I updated the loca table at some point to return Result<Option<.. to capture this but it didn't feel good.
There was a problem hiding this comment.
Interesting idea, maybe worth opening an issue to discuss? It's true that something has probably gone wrong if you ever have a simple or composite glyph that's empty, I'm not sure how that would happen intentionally.
This adds a loca module and a Loca table, and also adds a Glyph enum to represent either a simple or composite glyph. A follow-up patch will add a builder type for constructing the glyf and loca tables.
cmyr
force-pushed
the
glyf-loca-improvements
branch
from
0af87b9
to
16d7b5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a loca module and a Loca table, and also adds a Glyph enum to represent either a simple or composite glyph.
A follow-up patch will add a builder type for constructing the glyf and loca tables.
I noticed that a lot of this stuff had been implemented in fontc, but it feels like it really belongs here.