iup_delta_optimize: fix interpretation of contour_ends #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ur lengths Towards fixing #564 Also needs corresponding changes in the fontc calling site
anthrotype
changed the title
anthrotype
added a commit
to googlefonts/fontc
that referenced
this pull request
Aug 10, 2023
Fixes googlefonts/fontations#564 requires googlefonts/fontations#565 to be released and write-fonts to be bumped first
|
this will a breaking change for fontc, should I also bump write-fonts minor version within this same PR, or you prefer a follow-up? |
anthrotype
added a commit
to googlefonts/fontc
that referenced
this pull request
Aug 10, 2023
Fixes googlefonts/fontations#564 requires googlefonts/fontations#565 to be released and write-fonts to be bumped first
dfrg
approved these changes
Aug 10, 2023
Probably a follow-up but current policy is merge without approval for version bumps. |
|
thanks for the review, yes it's ready but we need to update write-fonts first before we can integrate this |
sorry, I meant before we can integrate googlefonts/fontc#390 |
anthrotype
added a commit
that referenced
this pull request
Aug 10, 2023
Bumped minor because #565 introduced a breaking change to iup_delta_optimize
anthrotype
added a commit
to googlefonts/fontc
that referenced
this pull request
Aug 10, 2023
Fixes googlefonts/fontations#564 requires googlefonts/fontations#565 to be released and write-fonts to be bumped first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564
the input and expected result is taken from what fontmake/fonttools spit out for Oswald's glyph "two"
EDIT: Commit 36a8929 also fixes #567