[skrifa] tthint: instruction dispatch #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an opcode definition, instruction representation and decoder for TrueType bytecode. Also renames Args -> InlineOperands and moves the type from skrifa to read-fonts.
Based on #773, uses the decoder in that PR to handle dispatch to the currently implemented instructions. No tests in this one. Will add in a later PR when more functionality has landed.
rsheeter
reviewed
Feb 7, 2024
rsheeter
reviewed
Feb 7, 2024
- add limit for total number of instructions executed (same as FT) - don't return count from Engine::run()
- move bytecode to glyf module - replace negation with abs() - make DecodeError a unit-like struct In addition, replace byte to Opcode table with a match expression. This codegens the same as transmute!
|
Following up here with completed changes suggested in #773:
In reference to #773 (comment), I looked at assembly for the table lookups and it turns out that bounds checks are elided, but memory accesses are not. However, replacing the body of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #773, uses the decoder in that PR to handle dispatch to the currently implemented instructions.
No tests in this one. Will add in a later PR when more functionality has landed.