Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skrifa] tthint: instruction dispatch #774

Merged
merged 5 commits into from
Feb 8, 2024
Merged

[skrifa] tthint: instruction dispatch #774

merged 5 commits into from
Feb 8, 2024

Commits on Feb 7, 2024

  1. [read-fonts] tt bytecode decoder

    Adds an opcode definition, instruction representation and decoder for TrueType bytecode.
    
    Also renames Args -> InlineOperands and moves the type from skrifa to read-fonts.
    dfrg committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9839450 View commit details
    Browse the repository at this point in the history
  2. [skrifa] tthint: instruction dispatch

    Based on #773, uses the decoder in that PR to handle dispatch to the currently implemented instructions.
    
    No tests in this one. Will add in a later PR when more functionality has landed.
    dfrg committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    cf7cd30 View commit details
    Browse the repository at this point in the history
  3. review feedback

    - add limit for total number of instructions executed (same as FT)
    - don't return count from Engine::run()
    dfrg committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    c6db440 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Configuration menu
    Copy the full SHA
    7590ffe View commit details
    Browse the repository at this point in the history
  2. review changes from #773

    - move bytecode to glyf module
    - replace negation with abs()
    - make DecodeError a unit-like struct
    
    In addition, replace byte to Opcode table with a match expression. This codegens the same as transmute!
    dfrg committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d2aba56 View commit details
    Browse the repository at this point in the history