Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rounding of VariationModel::deltas #1070

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Commits on Oct 28, 2024

  1. add minimal reproducer for #1043

    where fontc' lack of rounding leads to deltas that are off-by-one compared with fontmake/fonttools in Gelasio's MVAR table
    
    #1043 (comment)
    anthrotype committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b6eea92 View commit details
    Browse the repository at this point in the history
  2. [VariationModel] use banker_round when computing deltas

    Fixes #1043 and #235
    
    This commit also adds a test from fonttools Tests/varLib/models_test.py that demostrates how our previous approach of late-rounding of deltas can actually lead to an excessive accummulation of rounding errors when the deltas are actually used for interpolation.
    anthrotype committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ecff0e7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba1d291 View commit details
    Browse the repository at this point in the history
  4. remove type parameters from RoundTiesEven trait

    they were indeed useless... thanks Colin
    anthrotype committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    66b997e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fe99214 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Configuration menu
    Copy the full SHA
    a5a2f26 View commit details
    Browse the repository at this point in the history