[crater] Compute and store 'hash' of python packages #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google generally favors flags to environment variables. I recommend we do the same. |
rsheeter
reviewed
Oct 29, 2024
| std::str::from_utf8(sha1sum.stdout.trim_ascii()) | ||
| .expect("shasum output always ascii") | ||
| .to_owned() | ||
| } |
There was a problem hiding this comment.
You don't really need a crytographic hash or to spawn although I suppose it's harmless enough
There was a problem hiding this comment.
this was just the quickest way I could think of to do this in a consistent and portable way. 🤷
rsheeter
approved these changes
Oct 29, 2024
This is a coarse way of determining whether or not any python packages have been modified, which we can use for invalidating a potential cache. Also adds a env var to force CI to rerun, which is something I often want during development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a coarse way of determining whether or not any python packages have been modified, which we can use for invalidating a potential cache.
Also adds a env var to force CI to rerun, which is something I often want during development.