Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONT MERGE: add failing test to repro #1043 #1087

Closed
wants to merge 1 commit into from
Closed

Conversation

anthrotype
Copy link
Member

@anthrotype anthrotype commented Nov 1, 2024

the deltas for Teachers-Italic.glyphs' ordfeminine 'top' anchor are off-by-one because the anchor's master values are un-rounded floats.

#1082 will fix this and similar others.

Related issue: #1043

the deltas for Teachers-Italic.glyphs' ordfeminine 'top' anchor are off-by-one because the anchor's master values are un-rounded floats.

#1082 will fix this and similar others.
@anthrotype anthrotype changed the title add failing test to repro #1043 DONT MERGE: add failing test to repro #1043 Nov 1, 2024
@anthrotype
Copy link
Member Author

https://github.com/googlefonts/fontc/actions/runs/11631453530/job/32392559377?pr=1087

Diff < left / right > :
 #mark:DFLT/dflt##2MarkToBaserules
 #lookupflagLookupFlag(0)
 a@(x:377{386,389},y:451{450,450})
 @(x:218{265,282},y:704{707,708})acutecomb
<ordfeminine@(x:283{289,292},y:691{689,689})
>ordfeminine@(x:283{290,292},y:691{690,690})
 @(x:218{265,282},y:704{707,708})acutecomb

@anthrotype anthrotype closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant