Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlyphPathBuilder: support contours starting with offcurves or without oncurves #385

Merged
merged 8 commits into from
Aug 9, 2023

Conversation

anthrotype
Copy link
Member

Fixes #349

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this looks good to me, and the tests/impl ratio is encouraging. A few little notes inline, but nothing major :)

glyphs2fontir/src/toir.rs Outdated Show resolved Hide resolved
fontir/src/ir.rs Outdated Show resolved Hide resolved
@anthrotype
Copy link
Member Author

anthrotype commented Aug 9, 2023

I'd like to merge this before it gets out of sync, I can address any review comments e.g. Rod may have once he gets back

@anthrotype anthrotype merged commit 097ab92 into googlefonts:main Aug 9, 2023
6 checks passed
@anthrotype anthrotype deleted the fix-leading-offcurves branch August 9, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Sans has outlines we don't like
2 participants