Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

must follow fvar axes order when building gvar GlyphDeltas #387

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

anthrotype
Copy link
Member

TupleBuilder was iterating over VariationRegion's axis_tents which is a BTreeMap, but it should instead iterate over the region's tents following the fvar's axis order, that's what the gvar Tuples must follow. Otherwise we store deltas for the wrong axes!

TupleBuilder was iterating over VariationRegion's axis_tents which is a BTreeMap, but it should instead iterate over the region's tents following the fvar's axis order, that's what the gvar Tuples must follow. Otherwise we store deltas for the wrong axes!
Copy link
Member

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I wonder if VariationRegion should be changed to store tents in axis order rather than using a map but I see at least one place where lookup is done by tag and changing that might be more invasive so this solution looks good to me.

@anthrotype
Copy link
Member Author

I wonder if VariationRegion should be changed to store tents in axis order

I wondered the same, maybe we can revise this later. I'll merge this for now

@anthrotype anthrotype merged commit 076d267 into main Aug 9, 2023
6 checks passed
@anthrotype anthrotype deleted the tuple-axis-order branch August 9, 2023 14:39
@rsheeter
Copy link
Contributor

Good catch, ty!

I wonder if VariationRegion should be changed to store tents in axis order

I wondered the same, maybe we can revise this later. I'll merge this for now

This looks pretty clear, I wouldn't worry about it unless we start seeing it cause problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants