Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MissingAxisTentError when building Oswald #427

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Fix MissingAxisTentError when building Oswald #427

merged 2 commits into from
Sep 5, 2023

Conversation

anthrotype
Copy link
Member

Fixes #426

I first push a reproducer to demostrate the bug, then follow up with the fix

@anthrotype
add noop axis to repro MissingAxisTentError #426
6560166
@anthrotype
fontbe/features.rs: must iterate over static_metadata.variable_axes, …
e55afdc 
…not just .axes

... just like in the line immediately above this, we initialized a Vec::with_capacity(self.static_metadata.variable_axes.len())

Otherwise if len(variable_axes) != len(axes) -- like in the case of Oswald -- we get spurious errors about Missing tent for <axis>

Fixes #426
@anthrotype
Copy link
Member Author

fontbe test failed as expected

thread 'features::tests::resolve_kern' panicked at 'called `Result::unwrap()` on an `Err` value:
MissingTentError(Tag(wdth))', fontbe/src/features.rs:681:14

dfrg
dfrg approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough and makes sense. Lgtm!

@anthrotype anthrotype added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit da4fd2a Sep 5, 2023
10 checks passed
@anthrotype anthrotype deleted the fix-missing-axis branch September 5, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfrg dfrg dfrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiling Oswald fails with 'Missing a tent for wdth'
2 participants
@anthrotype @dfrg