Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MissingAxisTentError when building Oswald #427

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Fix MissingAxisTentError when building Oswald #427

merged 2 commits into from
Sep 5, 2023

Commits on Sep 5, 2023

  1. add noop axis to repro MissingAxisTentError #426

    @anthrotype
    anthrotype committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    6560166 View commit details
    Browse the repository at this point in the history

  2. fontbe/features.rs: must iterate over static_metadata.variable_axes, … 

    …not just .axes

... just like in the line immediately above this, we initialized a Vec::with_capacity(self.static_metadata.variable_axes.len())

Otherwise if len(variable_axes) != len(axes) -- like in the case of Oswald -- we get spurious errors about Missing tent for <axis>

Fixes #426
    @anthrotype
    anthrotype committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e55afdc View commit details
    Browse the repository at this point in the history