Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor glyph info lookup #779

Open
schriftgestalt opened this issue Feb 22, 2022 · 1 comment
Open

Refactor glyph info lookup #779

schriftgestalt opened this issue Feb 22, 2022 · 1 comment

Comments

@schriftgestalt
Copy link
Collaborator

schriftgestalt commented Feb 22, 2022

I just had a look at the way the glyph info is generated (from looking at Jans pull request #778).

There are two (or three) function that do ligature lookup (in _construct_production_name, _construct_category and soon _construct_script). I would recommend to put the fallback into _lookup_attributes (or make a new one like _lookup_attributes_with_fallback). So that it returns the needed attributes for all names that it can recognize. (or rename _lookup_attributes to _lookup_attributes_data and make a new _lookup_attributes)

I can have a look when the pull request is merged.

@madig
Copy link
Collaborator

madig commented Oct 2, 2022

This reminds me, have you posted your algorithm for (sub)category determination anywhere? The code in glyphsLib continues to scare me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants