Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaping_differs to allow >=2 items, added defs for nl_Latn and tr_Latn #38

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yanone
Copy link
Contributor

@yanone yanone commented Dec 6, 2023

No description provided.

@yanone yanone marked this pull request as draft December 8, 2023 11:01
@yanone yanone marked this pull request as ready for review January 10, 2024 16:06
@yanone
Copy link
Contributor Author

yanone commented Jan 10, 2024

I'm done with this. Please review the shaping_differs check carefully, because I still didn't fully get what the differs notation is about. But I believe that, from looking at the code alone, I properly translated it to allow >=2 items. For execute() I basically just created permutations and looped over them, leaving all other code unchanged.

There are now assert statements in execute() that assure input items to be >=2, with corresponding differs items, since I couldn't find any item count specifications in StrictYAML. You may want to have these error messages in another form and/or place.

@yanone yanone changed the title Create nl_Latn.yaml Shaping_differs to allow >=2 items, added defs for nl_Latn and tr_Latn Jan 10, 2024
@yanone
Copy link
Contributor Author

yanone commented Jan 10, 2024

I think actually we need to add a manually defined test for the change in the check (mostly the differs part), since there aren't any definitions using this notation yet. But I don't know how to define a test because I don't fully understand what's going on. Could you please contribute this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant