Adds “fontdata” generated files to ignore #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the generated CSS and data files to the
.gitignore
, and re-creates them on every build instead.If you had a massive amount of fonts in a single repo, I can see how it would be beneficial to only generate the data when the command is run.
Here’s my thinking for a typical setup though: it’s already fast, and this way it’s clear that these are generated files and not source fils that you need to commit. Someone else can also update the font files only, and the CI process will handle the data build from there. (I could even see changing the run command name to
build:fontdata
.)Let me know what you think, though! Thanks.