Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds “fontdata” generated files to ignore #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kennethormandy
Copy link

This adds the generated CSS and data files to the .gitignore, and re-creates them on every build instead.

If you had a massive amount of fonts in a single repo, I can see how it would be beneficial to only generate the data when the command is run.

Here’s my thinking for a typical setup though: it’s already fast, and this way it’s clear that these are generated files and not source fils that you need to commit. Someone else can also update the font files only, and the CI process will handle the data build from there. (I could even see changing the run command name to build:fontdata.)

Let me know what you think, though! Thanks.

@RoelN
Copy link
Collaborator

RoelN commented May 17, 2024

@pascalw What do you think? Sounds sane!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants