Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build:* and start:* need single quotes to work on macOS #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twardoch
Copy link

@twardoch twardoch commented Jan 2, 2024

When running 'yarn build' or 'yarn start' on macOS with Bash & Node v21.1.0, you get an error because * gets interpreted as a glob pattern. Surround the specs with ' to make it work.

What

Explain what changes inside the code, this can be as simple or complicated as you want as long as it's clear

Why

Explain why these things are changes. This explanation is for your colleagues and your future self.

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • Does the code actually solve the problem it was meant to solve?
  • Is the code covered by unit tests? Integration tests?
  • Does anything here need documentation? (Focus on why, not what.)
  • Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • Is the code easy to understand and change in the future?
  • Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • Does the code reasonably adhere to the Kabisa coding standards?
  • Be kind.

When running 'yarn build' or 'yarn start' on macOS with Bash & Node v21.1.0, you get an error because * gets interpreted as a glob pattern. Surround the specs with ' to make it work.
@RoelN
Copy link
Collaborator

RoelN commented May 17, 2024

@twardoch I completely missed this PR, thanks for your contribution, and your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants