Merge pull request #774 from googlefonts/fix-pref-names

keep or drop nameID=16 and 17 only when *both* == 1 and 2
googlefonts · Aug 4, 2023 · b3895a9 · b3895a9
2 parents d1c5ad4 + e931d18
commit b3895a9
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/Lib/ufo2ft/outlineCompiler.py b/Lib/ufo2ft/outlineCompiler.py
@@ -415,10 +415,9 @@ def setupTable_name(self):
             22: getAttrWithFallback(font.info, "openTypeNameWWSSubfamilyName"),
         }
 
-        # don't add typographic names if they are the same as the legacy ones
-        if nameVals[1] == nameVals[16]:
+        # don't add typographic names if *both* are the same as the legacy ones
+        if nameVals[1] == nameVals[16] and nameVals[2] == nameVals[17]:
             del nameVals[16]
-        if nameVals[2] == nameVals[17]:
             del nameVals[17]
         # postscript font name
         if nameVals[6]: