Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark2liga missing from binary font #663

Closed
yanone opened this issue Oct 5, 2022 · 2 comments
Closed

mark2liga missing from binary font #663

yanone opened this issue Oct 5, 2022 · 2 comments

Comments

@yanone
Copy link

yanone commented Oct 5, 2022

Here’s another anomaly with ufo2ft and my proprietary font (see #658):

The feature code as output by --debug-feature-file does contain ligature attachments:

        pos ligature lam_alef-ar
                <anchor 330 -56> mark @MC_bottom
                <anchor 430 742> mark @MC_top
            ligComponent
                <anchor 123 -56> mark @MC_bottom
                <anchor 111 613> mark @MC_top;

But the binary file doesn't contain ligature attachment, only base attachment:
Bildschirmfoto 2022-10-05 um 17 00 13

I’ve searched the output of otf2fea and also couldn’t find any pos ligature statements, so I truly believe they are missing from the font.

This is happening both in ufo2ft=2.28.0 as well as with the repository’s main.
Please let me know if I can be of any help in debugging this.

@anthrotype
Copy link
Member

that's strange.
When you dump with ttx do you not see any LookupType="5" (for MarkToLigature lookup subtables) in GPOS LookupList?
Is this a VF or a static font?
Try to see if you can reproduce with a minimal glyph set. If it stills has the issue, maybe remove the actual glyph drawings and upload a reproducer here, stripped of any proprietary stuff.

@yanone
Copy link
Author

yanone commented Oct 7, 2022

Reducing the font to the bare minimum actually helped me find the issue: The lam_alef ligature shown is actually the result of a contextual substitution that shows a lower alef when marks are present. This lam_alef-ar.short wasn’t getting categorized as a ligature by Georg’s WIP glyphsLib branch that I need for the RTL kerning. If I set the subCategory in Glyphs explicitly, it works. I've added a test case to Georg’s branch.

@yanone yanone closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants