Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible logic error in getScriptLanguageSystems #822

Open
cmyr opened this issue Feb 28, 2024 · 0 comments
Open

Possible logic error in getScriptLanguageSystems #822

cmyr opened this issue Feb 28, 2024 · 0 comments

Comments

@cmyr
Copy link
Member

cmyr commented Feb 28, 2024

On the following line in this function, the sc value may be None, but this case does not appear to be handled, which means that the returned map could contain an unexpected None value.

The called function currently returns None if the tag is DFLT, which we skip earlier in this function so this is probably fine? but future changes might break this, and it might make sense to check this value before inserting it in the map.

sc = unicodedata.ot_tag_to_script(script)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant