add ftConfig parameter to set fontTools' TTFont.cfg options #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
force-pushed
the
fonttools-config
branch
from
604445a
to
06c4f8b
Compare
anthrotype
force-pushed
the
fonttools-config
branch
from
06c4f8b
to
8ebd175
Compare
anthrotype
changed the title
|
at the risk of bikeshedding.. do we all like the name |
anthrotype
force-pushed
the
fonttools-config
branch
from
8ebd175
to
05d6a1e
Compare
anthrotype
force-pushed
the
fonttools-config
branch
from
05d6a1e
to
0e19a17
Compare
and use it to pass fontTools.otlLib.optimize.gpos:COMPRESSION_LEVEL instead of env var
anthrotype
force-pushed
the
fonttools-config
branch
from
0e19a17
to
5b4d18f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
ftConfigparameter to all compile methods that allows to set fonttools configuration options as defined in (e.g. to turn on/off the serialization of GPOS/GSUB with the harfbuzz repacker):https://github.com/fonttools/fonttools/blob/main/Lib/fontTools/config/__init__.py
since these config options are set on the TTFont instance itself (in its cfg attribute) but ufo2ft creates a new TTFont instance from scratch, this new parameter will allow a client (e.g. fontmake) to specify these options and have ufo2ft configure the newly created TTFont object with them.