Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile variable features #635

Merged
merged 17 commits into from
Jan 11, 2024
Merged

Compile variable features #635

merged 17 commits into from
Jan 11, 2024

Commits on Jan 10, 2024

  1. Util scaffolding 

    * Using this version of otRound allows us to reuse a lot more code
* A couple of variable scalar / designspace utility functions
* Allow compileGSUB to know about fvar tables
    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    0fae115 View commit details
    Browse the repository at this point in the history

  2. Here come the variable feature writer implementations

    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    dadd828 View commit details
    Browse the repository at this point in the history

  3. Add a VariableFeatureCompiler 

    This is the same as a FeatureCompiler but it knows its designspace and
it also loads the RulesFeatureWriter if there are any designspace rules
    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f1b3ef4 View commit details
    Browse the repository at this point in the history

  4. Hook up variable feature compilation to __init__.py

    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    dd278fc View commit details
    Browse the repository at this point in the history

  5. Some tests for variable feature writing 

    Add test for different feature writers

Fix up test expectations

This should now test the variable features
    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    d0252b6 View commit details
    Browse the repository at this point in the history

  6. Slightly improve the subclassing

    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f997b24 View commit details
    Browse the repository at this point in the history

  7. Stash and return glyphsets, then find the default glyphset when compi… 

    …ling variable features
    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    5122946 View commit details
    Browse the repository at this point in the history

  8. On reflection these not needed

    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6473bbb View commit details
    Browse the repository at this point in the history

  9. Use shiny new fonttools API

    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a591759 View commit details
    Browse the repository at this point in the history

  10. otRound the position when building a variable anchor

    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    30b6be6 View commit details
    Browse the repository at this point in the history

  11. Use getAnchor to get variable ligcarets

    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    809324f View commit details
    Browse the repository at this point in the history

  12. Log progress

    @simoncozens @anthrotype
    simoncozens authored and anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    1f3f179 View commit details
    Browse the repository at this point in the history

  13. remove unused parameter

    @anthrotype
    anthrotype committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    91e76cd View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. add compile option to force variableFeatures=False 

    this can be useful to debugging, comparing build time of new vs old build pipeline, or if one wants to ensure no binary changes occur when updating the compiler
    @anthrotype
    anthrotype committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    52ca46a View commit details
    Browse the repository at this point in the history

  2. be more generic in log message emitted for either TTF or CFF2 VFs

    @anthrotype
    anthrotype committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    207f247 View commit details
    Browse the repository at this point in the history

  3. remove unused parameter

    @anthrotype
    anthrotype committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    a375806 View commit details
    Browse the repository at this point in the history

  4. restore log message that got lost in #801 refactoring

    @anthrotype
    anthrotype committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    a782bbf View commit details
    Browse the repository at this point in the history