Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split kerning by script, not by direction (second attempt) #667

Closed
wants to merge 107 commits into from
Closed

Split kerning by script, not by direction (second attempt) #667

wants to merge 107 commits into from

Commits on Nov 4, 2022

  1. Split kerning by script, not by direction (#636)

    @simoncozens @madig
    simoncozens authored and madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    8315c29 View commit details
    Browse the repository at this point in the history

  2. Annotate KerningPair

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    c049bc6 View commit details
    Browse the repository at this point in the history

  3. Some set syntax simplification

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f3db45f View commit details
    Browse the repository at this point in the history

  4. Revert "Rewind test case" 

    This reverts commit 77c4ca5.
    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0d65864 View commit details
    Browse the repository at this point in the history

  5. Add some typing

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    d782045 View commit details
    Browse the repository at this point in the history

  6. Use Hashable instead

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7ac9db8 View commit details
    Browse the repository at this point in the history

  7. Stop using Hashable actually 

    Hashable and tuple seem to clash.
    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    54257e8 View commit details
    Browse the repository at this point in the history

  8. Add commentary about lookup sorting

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    481c702 View commit details
    Browse the repository at this point in the history

  9. Add typing for KerningPair.getKerningPairs

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    85f4915 View commit details
    Browse the repository at this point in the history

  10. Remove leftover typing comment

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    8400082 View commit details
    Browse the repository at this point in the history

  11. Add missing return type

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f4409a0 View commit details
    Browse the repository at this point in the history

  12. Derive scripts from glyphs, not languagesystems

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    b96addb View commit details
    Browse the repository at this point in the history

  13. WIP: Split kerning at source

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    300c862 View commit details
    Browse the repository at this point in the history

  14. Add cleared-out test sources with permission from @yanone

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    875cf24 View commit details
    Browse the repository at this point in the history

  15. Use imported sources

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    664c07d View commit details
    Browse the repository at this point in the history

  16. Simplify pair splitting logic

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    e308b13 View commit details
    Browse the repository at this point in the history

  17. WIP: some test

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    322dc04 View commit details
    Browse the repository at this point in the history

  18. Add sanity checking

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    9b7d6a3 View commit details
    Browse the repository at this point in the history

  19. Remove unused import

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    af51288 View commit details
    Browse the repository at this point in the history

  20. Preserve KerningPair type when splitting

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    8e7875e View commit details
    Browse the repository at this point in the history

  21. WIP: rewrite some code for clarity

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    d25e20c View commit details
    Browse the repository at this point in the history

  22. Refactor: move script inference into setContext

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    e994eb6 View commit details
    Browse the repository at this point in the history

  23. WIP: add some todos and tiny refactor

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    82a69b0 View commit details
    Browse the repository at this point in the history

  24. Merge some methods into _makeSplitScriptKernLookups 

    They were trivial and only called from one place.
    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    8a6a128 View commit details
    Browse the repository at this point in the history

  25. Add typing to _makeSplitScriptKernLookups

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    041b7a4 View commit details
    Browse the repository at this point in the history

  26. glyphScripts should be immutable

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    bf8568a View commit details
    Browse the repository at this point in the history

  27. Add more typing

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0378139 View commit details
    Browse the repository at this point in the history

  28. More WIP experimentation

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    c3e0f0c View commit details
    Browse the repository at this point in the history

  29. More WIPing

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    90682e8 View commit details
    Browse the repository at this point in the history

  30. Add to docstring of BaseFeatureWriter.write

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    c005ab4 View commit details
    Browse the repository at this point in the history

  31. Add TODO

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    6b66162 View commit details
    Browse the repository at this point in the history

  32. Keep RTL logic in one place

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    ef24b3b View commit details
    Browse the repository at this point in the history

  33. Post-process split kerning pairs

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    5bbf9a9 View commit details
    Browse the repository at this point in the history

  34. WIP: insert newly generated class names 

    Crashes on a certain font project, needs more work
    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    987e9f2 View commit details
    Browse the repository at this point in the history

  35. WIP: prune Zyyy membership if also member of soimething else

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    c1dfc61 View commit details
    Browse the repository at this point in the history

  36. Amend comment 

    [skip ci]
    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    e110c5e View commit details
    Browse the repository at this point in the history

  37. implement __eq__ for KerningPair

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    b22c06f View commit details
    Browse the repository at this point in the history

  38. Simplify kern splitting and avoid emitting mixed common script pairs

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    797d1f3 View commit details
    Browse the repository at this point in the history

  39. WIP: help

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    2694b9e View commit details
    Browse the repository at this point in the history

  40. Clarify exception 

    [skip ci]
    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    df103a9 View commit details
    Browse the repository at this point in the history

  41. Drop cleverness again for now

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f2f7b74 View commit details
    Browse the repository at this point in the history

  42. More refactoring plus more tests

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f372559 View commit details
    Browse the repository at this point in the history

  43. Fill in test 

    And tone down membership test
    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    b329fc8 View commit details
    Browse the repository at this point in the history

  44. Treat common+other glyphs as common

    @simoncozens @madig
    simoncozens authored and madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    a948fab View commit details
    Browse the repository at this point in the history

  45. Don't expect common/common to be emitted twice

    @simoncozens @madig
    simoncozens authored and madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    49880e4 View commit details
    Browse the repository at this point in the history

  46. Register lookups irregardless of global languagesystems

    @madig
    madig committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7e0eb95 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. Clarify invariant 

    [skip ci]
    @madig
    madig committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    1b549ff View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Update TTX dumps

    @madig
    madig committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    79a69e8 View commit details
    Browse the repository at this point in the history

  2. Split lookups into kern and dist 

    Removes some stale code that used the globally defined language systems.
    @madig
    madig committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    bdf96f0 View commit details
    Browse the repository at this point in the history

  3. Read ignoreMarks option in one place

    @madig
    madig committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    7a2e6be View commit details
    Browse the repository at this point in the history

  4. Adapt tests to current code

    @madig
    madig committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    0d53f62 View commit details
    Browse the repository at this point in the history

  5. Catch feature compilation failures from feature writers

    @madig
    madig committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    6e08952 View commit details
    Browse the repository at this point in the history

  6. isort

    @madig
    madig committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f6d414e View commit details
    Browse the repository at this point in the history

  7. Fix lints

    @madig
    madig committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    5d88e0e View commit details
    Browse the repository at this point in the history

  8. Simplify getKerningPairs

    @madig
    madig committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    3a04b47 View commit details
    Browse the repository at this point in the history

  9. Quantize kerning values early on

    @madig
    madig committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    6c58cfb View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Actually sort in getKerningPairs 

    This found something in a font that used all combinations of glyph and
class pairing for two glyphs.
    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3f0c2e4 View commit details
    Browse the repository at this point in the history

  2. Fix unique pair filtering

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3a4f6cf View commit details
    Browse the repository at this point in the history

  3. Move _makePairPosRule into KerningPair

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    846088f View commit details
    Browse the repository at this point in the history

  4. Remove KerningPair.directions attribute

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    cef3a58 View commit details
    Browse the repository at this point in the history

  5. Remove stale comments

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    d6d1e3d View commit details
    Browse the repository at this point in the history

  6. Update comment

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    7402945 View commit details
    Browse the repository at this point in the history

  7. Drop groupby for disjointment

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    a566573 View commit details
    Browse the repository at this point in the history

  8. Remove disjointment 

    It seems unecessary now.
    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    8e2ac01 View commit details
    Browse the repository at this point in the history

  9. Try harder to make KerningPairs always sort the same

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    991c799 View commit details
    Browse the repository at this point in the history

  10. Update docstring

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    0f5b027 View commit details
    Browse the repository at this point in the history

  11. Remove unused imports

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    ed362fa View commit details
    Browse the repository at this point in the history

  12. Refactor ensure_no_duplicates into own function

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    1578114 View commit details
    Browse the repository at this point in the history

  13. Just use (first|second)Glyphs for order and eq testing

    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    9efc96b View commit details
    Browse the repository at this point in the history

  14. Add comment 

    [skip ci]
    @madig
    madig committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    43a94be View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Use ufo2ft.Error instead of generic Exception

    @madig
    madig committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    2781b23 View commit details
    Browse the repository at this point in the history

  2. Stop writing out classDefs

    @madig
    madig committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    827e374 View commit details
    Browse the repository at this point in the history

  3. Sort imports

    @madig
    madig committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    f88609f View commit details
    Browse the repository at this point in the history

  4. Refactor out make_split_script_kern_lookups

    @madig
    madig committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    35b3e21 View commit details
    Browse the repository at this point in the history

  5. Move interesting tests over

    @madig
    madig committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    6fb8bf6 View commit details
    Browse the repository at this point in the history

  6. Repurpose test

    @madig
    madig committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    6599afe View commit details
    Browse the repository at this point in the history

  7. Turn into integration test

    @madig
    madig committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    d2f9eb3 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Consolidate new tests and make integration tests

    @madig
    madig committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    51e5f43 View commit details
    Browse the repository at this point in the history

  2. Minor line move because it looks better

    @madig
    madig committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    51b5735 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Add comment 

    [skip ci]
    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    8914b08 View commit details
    Browse the repository at this point in the history

  2. Simplify _registerLookups

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    7471f8c View commit details
    Browse the repository at this point in the history

  3. Remove redundant context variable

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    7d0ec88 View commit details
    Browse the repository at this point in the history

  4. Mark _splitBaseAndMarkPairs a static method

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    a8adf6c View commit details
    Browse the repository at this point in the history

  5. Translate test into integration test

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    7d13cb6 View commit details
    Browse the repository at this point in the history

  6. Remove unused import

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    a1b7aa7 View commit details
    Browse the repository at this point in the history

  7. Mark _splitBaseAndMarkPairs a static method

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    eee7a76 View commit details
    Browse the repository at this point in the history

  8. Write scripts and bidiTypes nito pairs up front

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    bbf002d View commit details
    Browse the repository at this point in the history

  9. Turn test into integration tests

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    88ff076 View commit details
    Browse the repository at this point in the history

  10. Remove now unused imports

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    20419a8 View commit details
    Browse the repository at this point in the history

  11. Remove redudant "or"

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    38c3303 View commit details
    Browse the repository at this point in the history

  12. WIP: try to simplify kerningpair 

    bidi types may not be treated right, see test_kern_split_and_mix_common -> nkoo

[skip ci]
    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    4015ba0 View commit details
    Browse the repository at this point in the history

  13. More WIP 

    [skip ci]
    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    0962d45 View commit details
    Browse the repository at this point in the history

  14. WIP: add test for bidis 

    [skip ci]
    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    f483564 View commit details
    Browse the repository at this point in the history

  15. WIP: add assert 

    [skip ci]
    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    9661866 View commit details
    Browse the repository at this point in the history

  16. Split and filter BiDi types correctly

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    3097ff5 View commit details
    Browse the repository at this point in the history

  17. Restore test to original

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    a314b7d View commit details
    Browse the repository at this point in the history

  18. Change logger messages

    @madig
    madig committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    b854e77 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. add comment 

    [skip ci]
    @madig
    madig committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    a0f7068 View commit details
    Browse the repository at this point in the history

  2. WIP 

    [skip ci]
    @madig
    madig committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    2ae3bad View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Simplify KerningPair by using tuples

    @madig
    madig committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    6ac95c8 View commit details
    Browse the repository at this point in the history

  2. Avoid sorting because we already did

    @madig
    madig committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    9ef27cd View commit details
    Browse the repository at this point in the history

  3. Move splitting and PairPos making into standalone functions

    @madig
    madig committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    f2826b0 View commit details
    Browse the repository at this point in the history

  4. Make KerningPair a dataclass

    @madig
    madig committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4459404 View commit details
    Browse the repository at this point in the history

  5. Remove stale comment 

    [skip ci]
    @madig
    madig committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    e44b0f3 View commit details
    Browse the repository at this point in the history

  6. Remove bidiTypes from KerningPair

    @madig
    madig committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    3a1752d View commit details
    Browse the repository at this point in the history

  7. Remove scripts from KerningPair

    @madig
    madig committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    2575bc6 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Remove redundant set

    @madig
    madig committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d07125e View commit details
    Browse the repository at this point in the history