Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep or drop nameID=16 and 17 only when *both* == 1 and 2 #774

Merged
merged 1 commit into from
Aug 4, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Lib/ufo2ft/outlineCompiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -415,10 +415,9 @@ def setupTable_name(self):
22: getAttrWithFallback(font.info, "openTypeNameWWSSubfamilyName"),
}

# don't add typographic names if they are the same as the legacy ones
if nameVals[1] == nameVals[16]:
# don't add typographic names if *both* are the same as the legacy ones
if nameVals[1] == nameVals[16] and nameVals[2] == nameVals[17]:
del nameVals[16]
if nameVals[2] == nameVals[17]:
del nameVals[17]
# postscript font name
if nameVals[6]:
Expand Down
Loading