Require latest fonttools and update integration tests #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the remaining failures should get fixed once fonttools/fonttools#3333 is merged/released |
Mostly the unused VarStore regions get pruned correctly now, after the VarStore gets optimized.
anthrotype
force-pushed
the
update-fonttools
branch
from
d3838fd
to
f51c9f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the differences in the integration tests' ttx files are due to a bug (that got fixed in intervening fonttools since we last updated ufo2ft) whereby unused regions weren't being correctly pruned when optimizing the ItemVariationStore, so they are good