[BaseIFilter] use cache to avoid recursing too much when gathering locations from component glyphs #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cations from component glyphs Some fonts have hundred of masters and many nested components, leading to this method seemingly hanging forever. Adding a cache avoids redoing the same work of gathering locations of all components in a composite glyph over and over again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fonts have hundreds of masters and many nested components, leading the
BaseIFilter.locationsFromComponentGlyphsmethod to seemingly hang in a very deep recursion loop.Adding a cache avoids re-doing the same work (of gathering locations of all nested components of a composite glyph) over and over again.