Make it easier to use variable features by allowing to put them in the default source only #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tures. This allows us to use variable features more easily by putting them in the default UFO only.
|
Any thoughts on this, @simoncozens, @anthrotype? |
|
LGTM, Cosimo is your man for ufo2ft though. |
|
hey sorry I was out last week, yes this LGTM thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using variable features, we currently get an error (
features.fea:6:5: Can't define a variable scalar in a non-variable font) unless all features in all sources are the same.This PR additionally allows variable features to be only added to the default source. Thus: if we have variable features in the default source, and no features in all other sources, ufo2ft will still follow the "use variable features" code path.
(Maybe
_featuresCompatible()should be renamed to something like_canOptimizeFeatures())