Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable kerning to old kern writer #841

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

madig
Copy link
Collaborator

@madig madig commented May 20, 2024

This upgrades the old kern writer to be able to output variable kerning for when you compile features once for a VF.

@madig madig marked this pull request as draft May 20, 2024 13:37
@madig madig marked this pull request as ready for review May 20, 2024 14:49
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment

@madig madig merged commit 8c895d0 into main May 22, 2024
9 checks passed
@madig madig deleted the upgrade-old-kern-writer branch May 22, 2024 09:14
@madig
Copy link
Collaborator Author

madig commented May 23, 2024

Ugh, the KerningPair parameters need to be converted. Why didn't I catch this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants