Use framework dialog where applicable (#153)

googlesamples · Aug 22, 2017 · 32ab68f · 32ab68f · Griffin641498 · May 23, 2022
1 parent 556b2ce
commit 32ab68f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/easypermissions/src/main/java/pub/devrel/easypermissions/RationaleDialogConfig.java b/easypermissions/src/main/java/pub/devrel/easypermissions/RationaleDialogConfig.java
@@ -54,7 +54,7 @@ Bundle toBundle() {
         return bundle;
     }
 
-    AlertDialog createDialog(Context context, Dialog.OnClickListener listener) {
+    AlertDialog createSupportDialog(Context context, Dialog.OnClickListener listener) {
         return new AlertDialog.Builder(context)
                 .setCancelable(false)
                 .setPositiveButton(positiveButton, listener)
@@ -63,4 +63,13 @@ AlertDialog createDialog(Context context, Dialog.OnClickListener listener) {
                 .create();
     }
 
+    android.app.AlertDialog createFrameworkDialog(Context context, Dialog.OnClickListener listener) {
+        return new android.app.AlertDialog.Builder(context)
+                .setCancelable(false)
+                .setPositiveButton(positiveButton, listener)
+                .setNegativeButton(negativeButton, listener)
+                .setMessage(rationaleMsg)
+                .create();
+    }
+
 }
diff --git a/easypermissions/src/main/java/pub/devrel/easypermissions/RationaleDialogFragment.java b/easypermissions/src/main/java/pub/devrel/easypermissions/RationaleDialogFragment.java
@@ -73,7 +73,7 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
                 new RationaleDialogClickListener(this, config, mPermissionCallbacks);
 
         // Create an AlertDialog
-        return config.createDialog(getActivity(), clickListener);
+        return config.createFrameworkDialog(getActivity(), clickListener);
     }
 
 }
diff --git a/easypermissions/src/main/java/pub/devrel/easypermissions/RationaleDialogFragmentCompat.java b/easypermissions/src/main/java/pub/devrel/easypermissions/RationaleDialogFragmentCompat.java
@@ -65,6 +65,6 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
                 new RationaleDialogClickListener(this, config, mPermissionCallbacks);
 
         // Create an AlertDialog
-        return config.createDialog(getContext(), clickListener);
+        return config.createSupportDialog(getContext(), clickListener);
     }
 }