Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed and responsive tracks #99

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

etowahadams
Copy link
Contributor

Adds documentation for track sizes (fixed or responsive).

docs/fixed-responsive.mdx Outdated Show resolved Hide resolved
Comment on lines 8 to 22
## Fixed size

A Gosling visualization can have a fixed size by setting the `width` and `height` properties. The tracks will have a fixed size regardless of the screen size.

When the `width` and `height` properties are set in the root of the spec, all tracks will have this height and width unless they are overridden in the track specification.

```javascript
{
// highlight-start
width: 800,
height: 200,
// highlight-end
// ... rest of the Gosling spec
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move this section down and bring the "Responsive size" up? I think it will better reflect the general interest of users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@sehilyi sehilyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested minor changes. Otherwise, this looks awesome!

etowahadams and others added 2 commits May 17, 2024 18:02
Co-authored-by: SEHI L'YI <sehilyi@gmail.com>
@etowahadams etowahadams merged commit f34ddd6 into main May 17, 2024
2 checks passed
@etowahadams etowahadams deleted the etowahadams/responsive branch May 17, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants