feat: fixed and responsive tracks #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehilyi
reviewed
May 17, 2024
sehilyi
reviewed
May 17, 2024
docs/fixed-responsive.mdx
Outdated
Comment on lines
8
to
22
| ## Fixed size | ||
|
|
||
| A Gosling visualization can have a fixed size by setting the `width` and `height` properties. The tracks will have a fixed size regardless of the screen size. | ||
|
|
||
| When the `width` and `height` properties are set in the root of the spec, all tracks will have this height and width unless they are overridden in the track specification. | ||
|
|
||
| ```javascript | ||
| { | ||
| // highlight-start | ||
| width: 800, | ||
| height: 200, | ||
| // highlight-end | ||
| // ... rest of the Gosling spec | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Could we move this section down and bring the "Responsive size" up? I think it will better reflect the general interest of users.
sehilyi
approved these changes
May 17, 2024
Co-authored-by: SEHI L'YI <sehilyi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for track sizes (fixed or responsive).