Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Copy/paste of new device URL is required in order to access QR code and Provenance Record #280

Open
vjaqua opened this issue Sep 19, 2024 · 7 comments · May be fixed by #287
Open

[BUG] Copy/paste of new device URL is required in order to access QR code and Provenance Record #280

vjaqua opened this issue Sep 19, 2024 · 7 comments · May be fixed by #287
Assignees
@bencoombs
Labels
bug Something isn't working

Comments

@vjaqua
Copy link
Collaborator

vjaqua commented Sep 19, 2024

Describe the bug
In order to access the QR Code and Provenance Record after creating New Device, I have to copy/paste the URL into a new tab. When I submit New Device, the page does not lead anywhere.Image
Image

Expected behavior
After creating New Device and clicking Submit, I expect the page to automatically load the QR code and Provenance Record.

Screenshots
Enclosed

Desktop:

  • Sonoma 14.6.1
  • Chrome
  • Version 128.0.6613.138

Additional context
A user will assume something is wrong if the page does not automatically lead to the QR code and Provenance Record.
@vjaqua vjaqua added the bug Something isn't working label Sep 19, 2024
@bencoombs
Copy link
Collaborator

bencoombs commented Sep 23, 2024 •
edited
Loading

When the submit button is clicked, the page should redirect to /device/. I have reproduced this locally and there are a few avenues I will explore.

Can you try recreate the error, and when it occurs, press F12 and post a screenshot of the console log?

Image

@vjaqua
Copy link
Collaborator Author

vjaqua commented Sep 24, 2024 •
edited
Loading

New device record made for this testing purpose
Image

@bencoombs
Copy link
Collaborator

Thanks for that test. Could you please repeat that but click on the console button and send a screenshot of the output? image

@vjaqua
Copy link
Collaborator Author

vjaqua commented Sep 24, 2024

Image

@vjaqua
Copy link
Collaborator Author

vjaqua commented Sep 24, 2024

There's a huge scroll bar of issues
Image

@bencoombs
Copy link
Collaborator

A layout error I noticed from this issue is that the footer is in the wrong place because there is no content. Fixed in: #285

@bencoombs
Copy link
Collaborator

I've found what I think is the cause of the bug and fixed it in this PR: https://github.com/gosqasorg/asset-provenance-tracking/tree/280-fix-new-device-workflow

I need to do some more testing before confirming.

@bencoombs bencoombs linked a pull request Sep 25, 2024 that will close this issue
Fix page not rendering correctly after creating a new device. #287
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bencoombs bencoombs

Labels
bug Something isn't working
Projects
GDT Project Planning
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix page not rendering correctly after creating a new device. gosqasorg/asset-provenance-tracking
2 participants
@bencoombs @vjaqua