Coco update toggle #188
Closed
Coco update toggle #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chihlinc
commented
Jun 24, 2024
chihlinc
commented
- change the toggle design.
* initial commit * fix for extra padding
* Fixed Device Page Text Styles * Fixed Device Page Text Styles
* changing function names * checking if entered child key exists * provenance records can be broken down into different lines now * removing textToLink class * fixing spacing
* moving create forms into a separate folder * input file button colors * change form bg colors to lighter blue (sky to frost) * change font color on input text placeholders: * changing borders * remove borders * children device name input box styled accordingly * clean up code * adding tag input field * notify all checkbox * clean code * Edited format a little to fit Figma * fix warning about notifyAll --------- Co-authored-by: K42IE <katiepryal@live.com>
* changes fix the error on npm run preview but fail on npm run dev * restore original * fork qrcode-vue3, change files locally * adding a submodule * pulling changes from qrcode submodule * moving all files from fork to fully local * renaming folder
* testing * anusha commentary license * Deploy Front End (#154) * remove frontend folder from workspaces add azure static web app config + deploy instructions * mroe readme * add link to azure SWA CLI * update package lock * Add GH action * add azure/static-web-apps-cli dev dependency * add deploy to github workflow (commented out temporarily) --------- Co-authored-by: Harry Pierson <harrypierson@outlook.com> * small change to trigger github action * move GH workflow file to correct folder * fix GH workflow * trigger wf * tweak wf * I can't believe I forgot the checkout action 🤦♂️ * fix upload wf step * deploy frontend GH WF step * node 18 * only run frontend deployment wf for frontend changes * Title bar is now a default layout (on all pages) (#169) * Inital commit * Made title-bar a default layout (also if you click the logoit goes to the main landing page) * Fix warnings (#174) * Inital commit * inital commit * inital commit (#184) * Fixed textTooLink warnings (#175) * Inital commit * inital commit * clean up * Nav-bar Formating Update (#187) * initial commit * fix for extra padding * Fixed Device Page Text Styling (#194) * Fixed Device Page Text Styles * Fixed Device Page Text Styles * create error when adding a child that does not exist (#162) * changing function names * checking if entered child key exists * provenance records can be broken down into different lines now * removing textToLink class * fixing spacing * Update main page to match style guide (#183) * moving create forms into a separate folder * input file button colors * change form bg colors to lighter blue (sky to frost) * change font color on input text placeholders: * changing borders * remove borders * children device name input box styled accordingly * clean up code * adding tag input field * notify all checkbox * clean code * Edited format a little to fit Figma * fix warning about notifyAll --------- Co-authored-by: K42IE <katiepryal@live.com> * Fix direct navigation to device page (#195) * changes fix the error on npm run preview but fail on npm run dev * restore original * fork qrcode-vue3, change files locally * adding a submodule * pulling changes from qrcode submodule * moving all files from fork to fully local * renaming folder --------- Co-authored-by: Harry Pierson <harrypierson@hotmail.com> Co-authored-by: Harry Pierson <harrypierson@outlook.com> Co-authored-by: K42IE <katiepryal@live.com> Co-authored-by: judithweng <83525666+judithweng@users.noreply.github.com> Co-authored-by: Robert L. Read <read.robert@gmail.com>
* button to download children * download button appear only when children are made * make the button appear only when there are children
* modified designedTag sintax * deleting comments
* WIP * remove pnpm package manager * fix http trigger * update the file * include filename in decryptBlob * Attachment-Name header * update the download * update get attachement test * add getAttachmentName backend function * update the frontend * Update retrieve the attachment name from the header * change front end on push GH action file name * add Backend push github action * add be build test on pr * update actions/checkout * update actions/setup-node --------- Co-authored-by: Harry Pierson <harrypierson@outlook.com> Co-authored-by: Coco Chen <chihlinc@cocos-mbp-3.mynetworksettings.com> Co-authored-by: Coco Chen <chihlinc@Cocos-MacBook-Pro-3.local>
…216) * initial checkin * linking about and contact page --------- Co-authored-by: judithweng <83525666+judithweng@users.noreply.github.com>
…et-provenance-tracking into coco-update-toggle
|
There is a git-related problem with PR: #188 . I believed you merged in a lot of recent (and valid) work, but the upshot is the PR changes 188 files! I don't believe this is the right way to do it. I assume to actually fix the toggle (which is the pupose of that PR) there are relatively few lines of code changed. Can you start over (development has more merged) and add into you PR only those lines that effect the toggle? We can meet about this and do it together if we have to (I know the git issue can be rather subtle. But this PR is slightly dangerous as it exists right now---I am going to close it. @chihlinc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.