Working on download function with the file name #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…co-harry-attachment trying to merge the backend logics and the frontend
…asset-provenance-tracking into coco-harry-attachment
devhawk
approved these changes
Jul 8, 2024
devhawk
reviewed
Jul 8, 2024
| const blob = await response.blob(); | ||
|
|
||
| // Fetch the attachment name | ||
| const nameResponse = await fetch(`${baseUrl}/attachment/${deviceKey}/${attachmentID}/name`, { |
There was a problem hiding this comment.
Should we check the response headers for attachment-name before calling into the attachment/${deviceKey}/${attachmentID}/name function? If deploying to the cloud resolves the CORS issue, we can avoid making two round trips every time.
|
Discussed this PR in today's meeting. Will merge after @chihlinc gets a chance to address my comment above and I have time to manually update the back end after merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.